Changeset cefe20d

Timestamp:

07/21/2023 04:43:01 PM (10 months ago)

Author:

Douglas R. Reno <renodr@…>

Branches:

12.0, 12.1, ken/TL2024, ken/tuningfonts, lazarus, plabs/newcss, python3.11, rahul/power-profiles-daemon, renodr/vulkan-addition, trunk, xry111/llvm18

Children:

a1ea6d4e

Parents:

9a23f3e

Message:

js102: Fix building on i686 again.

The default build configuration in 102.13 appears to have moved back to
GCC. Rather than change it, let's just modify math_private.h again with
a simpler tweak to allow it to build properly again (wrapped in a case
statement).

This particular problem resurfacing is quite odd. I can confirm that
js-102.12.0 does work though, but updated due to the JS CVE.

Firefox 115.x works well on i686 and builds without any tweaks, so
whenever we move to js115, this should not be a problem anymore.

Files:

• general/genlib/js102.xml (modified) (2 diffs)
• introduction/welcome/changelog.xml (modified) (1 diff)

general/genlib/js102.xml

@@ -148 +148 @@
     </note>
 <!-- not needed when using clang.  Upstream bug at
-     https://bugzilla.mozilla.org/show_bug.cgi?id=1729459
+    https://bugzilla.mozilla.org/show_bug.cgi?id=1729459.
+    07-21-2023: Issue has resurfaced again when using the default build
+                instructions for JS (which uses GCC). The problem is not present
+                in Firefox 115 though (which works OK on i686). -renodr
+-->
 
     <para>
@@ -156 +160 @@
 
 <screen><userinput>case "$(uname -m)" in
-    i?86) sed -e '/typedef[ ]*double/s/double/long double/' \
+    i?86) sed -e 's/typedef double/typedef long double/' \
               -i modules/fdlibm/src/math_private.h ;;
 esac</userinput></screen>
--->
+
     <para>
       Install <application>JS</application> by running the following

introduction/welcome/changelog.xml

@@ -39 +39 @@
     </listitem>
     -->
+   <listitem>
+     <para>July 21st, 2023</para>
+     <itemizedlist>
+       <listitem>
+         <para>[renodr] - Fix building JS-102 on i686. Firefox is unaffected
+         this time since the underlying problem is fixed in 115.x.</para>
+       </listitem>
+     </itemizedlist>
+   </listitem>
+
    <listitem>
      <para>July 20th, 2023</para>