Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#3790 closed enhancement (fixed)

Firefox/Xulrunner 19.0.2

Reported by: Armin K Owned by: Randy McMurchy
Priority: normal Milestone:
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description

Attachments (1)

Bug-722975-Make-system-cairo-work-again.patch (1.6 KB ) - added by ken@… 11 years ago.

Download all attachments as: .zip

Change History (17)

comment:1 by Wayne Blaszczyk, 11 years ago

The sed -i 's/\(MOZ_PKG_FATAL_WARNINGS =\).*/\1 0/' line under Command Explanations should be removed if no longer required.

comment:2 by Armin K, 11 years ago

Summary: Firefox/Xulrunner 18.0.2Firefox/Xulrunner 19.0

comment:3 by Randy McMurchy, 11 years ago

Owner: changed from blfs-book@… to Randy McMurchy
Status: newassigned

I can catch this one as I'm just now installing Firefox.

comment:4 by Randy McMurchy, 11 years ago

Has anyone tried building (and using) Firefox with system-installed Cairo? I know it has been broken and I don't see anything that shows that it would work with the version 19 of Firefox.

Unless someone can confirm that Firefox-19.0 works with system installed Cairo, I will leave the instructions to use the in-tree version of Cairo.

comment:5 by rt, 11 years ago

Firefox 19 fails to build for me when using --enable-system-cairo with the following error:

/sources/mozilla-release/gfx/thebes/gfxPlatform.cpp: In member function ‘virtual mozilla::RefPtr<mozilla::gfx::SourceSurface> gfxPlatform::GetSourceSurfaceForSurface(mozilla::gfx::DrawTarget*, gfxASurface*)’:
/sources/mozilla-release/gfx/thebes/gfxPlatform.cpp:655:53: error: ‘cairo_null_surface_create’ was not declared in this scope
/sources/mozilla-release/gfx/thebes/gfxPlatform.cpp:660:95: error: ‘cairo_surface_attach_snapshot’ was not declared in this scope

I'm using cairo 1.12.14.

comment:6 by ken@…, 11 years ago

The attachment is from debian - instead of altering cairo they alter firefox/xulrunner. I've used it with ff18 and it seems to work, but I don't have a list of the past problems so I can't say for certain that it solves them.

comment:7 by Armin K, 11 years ago

I tried the patch and it does the same as expose_snapshot patch for Cairo does - it breaks some flash stuff/images on certain sites, I don't remember the URLs right now.

Just leave it with internal cairo.

in reply to:  7 ; comment:8 by ken@…, 11 years ago

Replying to Krejzi:

I tried the patch and it does the same as expose_snapshot patch for Cairo does - it breaks some flash stuff/images on certain sites, I don't remember the URLs right now.

Just leave it with internal cairo.

Agreed : I'm now running firefox with the included cairo, and some video links that always came up black before now seem to work. Thanks for that comment, I didn't know you had tried it.

Not sure if anything else needs cairo tee.

in reply to:  8 comment:9 by Randy McMurchy, 11 years ago

Replying to ken@…:

Replying to Krejzi:

Just leave it with internal cairo.

Agreed : I'm now running firefox with the included cairo, and some video links that always came up black before now seem to work. Thanks for that comment, I didn't know you had tried it.

Not sure if anything else needs cairo tee.

I do not believe there is from what I've read. And if that is the case, we should probably dump the --enable-tee from the Cairo instructions as it is experimental.

comment:10 by Armin K, 11 years ago

Hello, any progress on this one? I can take it if you don't mind ... I'll be upgrading Thunderbird tomorrow ...

comment:11 by Randy McMurchy, 11 years ago

I already have changes in my sandbox. Please don't modify the file. I will be committing it today.

comment:12 by Armin K, 11 years ago

Summary: Firefox/Xulrunner 19.0Firefox/Xulrunner 19.0.1

comment:13 by Armin K, 11 years ago

Summary: Firefox/Xulrunner 19.0.1Firefox/Xulrunner 19.0.2

comment:14 by Armin K, 11 years ago

Please commit any changes you've made, I'll be upgrading to 19.0.2 shortly so I don't destroy any of your work.

comment:15 by Armin K, 11 years ago

Resolution: fixed
Status: assignedclosed

I've just changed md5sums, tarball sizes and build sizes to match my setup - 64bit LFS and system libs.

Updated to 19.0.2 in r11078.

I hope I didn't screw up any of your changes - unless they were md5sums/{download,build} size only changes like mine.

comment:16 by bdubbs@…, 10 years ago

Milestone: current

Milestone current deleted

Note: See TracTickets for help on using tickets.