Changeset 0cbc592a

Timestamp:

07/14/2024 10:21:45 AM (2 months ago)

Author:

Xi Ruoyao <xry111@…>

Branches:

12.2, gimp3, lazarus, trunk, xry111/for-12.3, xry111/spidermonkey128

Children:

e407e64

Parents:

273bb5a

Message:

libical: Fix/document ICU-75 related issue

I've noticed the issue for a long time. Part of it is a trivial
compatibility issue which can be solved by a sed. But it seems the
islamic calender is still broken.

File:

• general/genlib/libical.xml (modified) (2 diffs)

general/genlib/libical.xml

@@ -96 +96 @@
   <sect2 role="installation">
     <title>Installation of libical</title>
+
+    <!-- https://github.com/libical/libical/pull/690 -->
+    <para>
+      If <xref linkend='icu'/> is installed, fix an incompatibility
+      with ICU 75 or later:
+    </para>
+
+    <screen><userinput>sed '/getKeywordValuesForLocale/s/NULL/""/' \
+    -i ../src/libical/icalrecur.c</userinput></screen>
 
     <para>
@@ -131 +140 @@
 <screen remap="doc"><userinput>make docs</userinput></screen>
 
+    <!-- https://github.com/libical/libical/pull/684
+         It looks like an ICU bug but I've not got time to investigate
+         carefully.  -->
     <para>
       To test the results, issue: <command>make test</command>.
-      <!-- One test, timezones, is known to fail on SysV systems. -->
-      <!-- On systemd, we symlink the current timezone to
-           /etc/localtime, which is what libical expects.
-           This is now done on SysV as well.-->
+      One test named <literal>icalrecurtest-r</literal> is known to fail.
     </para>