Changeset 3fbdcfc

Timestamp:

11/22/2022 07:49:17 AM (17 months ago)

Author:

Xi Ruoyao <xry111@…>

Branches:

11.3, 12.0, 12.1, kea, ken/TL2024, ken/inkscape-core-mods, ken/tuningfonts, lazarus, lxqt, plabs/newcss, plabs/python-mods, python3.11, qt5new, rahul/power-profiles-daemon, renodr/vulkan-addition, trunk, xry111/llvm18, xry111/xf86-video-removal

Children:

fc88f1f

Parents:

07b7046

Message:

mutter: use --buildtype=debugoptimized for now ...

instead of --buildtype=release to work around a crash in gnome-shell.

Upstream issue: ​https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5512

If close an focused app window via the Activities overview, an assertion
fail will be triggered in clutter_actor_get_preferred_{width,height}.
When debug is disabled, the assertions are disabled as well and the
issue turns into a NULL dereference, leading to a crash.

This is definitely not a proper fix. But the issue has been haunting
gnome-42 and 43, and the upstream has not given any response yet.

Note that it's not a "compiler misoptimization" issue. The assertion
fails even with -O0, i. e. if both the assertions and compiler
optimization are disabled, gnome-shell will crash as well.

File:

• gnome/platform/mutter.xml (modified) (3 diffs)

gnome/platform/mutter.xml

@@ -161 +161 @@
 cd    build &&
 
-meson --prefix=/usr --buildtype=release -Dtests=false .. &&
+meson --prefix=/usr --buildtype=debugoptimized -Dtests=false .. &&
 ninja</userinput></screen>
 
@@ -197 +197 @@
       linkend='xwayland'/>.
 
-      You should also replace <parameter>--buildtype=release
-      -Dtests=false</parameter> in the <command>meson</command> command, with
-      <parameter>--buildtype=debugoptimized -Dtests=true</parameter>.  The test
+      You should also replace <parameter>-Dtests=false</parameter> in the
+      <command>meson</command> command, with
+      <parameter>-Dtests=true</parameter>.  The test
       suite requires the mutter schema to be installed on the system, so it is
       better to run the tests after installing the package.
@@ -227 +227 @@
     <title>Command Explanations</title>
 
+    <!-- https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5512
+         If debug is disabled, the "assertion 'CLUTTER_IS_ACTOR (self)'
+         failed" message will turn into a crash.  Enabling debug is just a
+         work around, it's not a proper fix.  -->
+    <para>
+      <parameter>--buildtype=debugoptimized</parameter>: Override the
+      default buildtype (<quote>debug</quote>), which would produce
+      unoptimized binaries.  It's used instead of
+      <option>--buildtype=release</option> to work around an issue
+      causing gnome-shell to crash.
+    </para>
+<!--
     <xi:include xmlns:xi="http://www.w3.org/2001/XInclude"
       href="../../xincludes/meson-buildtype-release.xml"/>
-
+-->
     <para>
       <parameter>-Dtests=false</parameter>: Prevents building the tests,