Changeset 60caf48

Timestamp:

03/06/2022 08:45:02 AM (2 years ago)

Author:

Xi Ruoyao <xry111@…>

Branches:

11.2, 11.3, 12.0, 12.1, kea, ken/TL2024, ken/inkscape-core-mods, ken/tuningfonts, lazarus, lxqt, plabs/newcss, plabs/python-mods, python3.11, qt5new, rahul/power-profiles-daemon, renodr/vulkan-addition, trunk, xry111/llvm18, xry111/soup3, xry111/xf86-video-removal

Children:

6c122387

Parents:

b5b1af68

git-author:

Xi Ruoyao <xry111@…> (03/06/2022 08:40:37 AM)

git-committer:

Xi Ruoyao <xry111@…> (03/06/2022 08:45:02 AM)

Message:

polkit: use archive tarball and enable tests

Normally we perfer release tarballs than archives. But for polkit, we
are using meson so the generated configure script is not needed. And,
the release tarball lacks test support files and prevents us from
running tests.

For such a "security related" package, skipping test seems not good...
(That being said, we'd been busying fix CVEs not found by the test. :( )

Files:

• introduction/welcome/changelog.xml (modified) (1 diff)
• postlfs/security/polkit.xml (modified) (3 diffs)

introduction/welcome/changelog.xml

@@ -45 +45 @@
       <para>March 6th, 2022</para>
       <itemizedlist>
+        <listitem>
+          <para>[xry111] - Download polkit from FDO GitLab and run its
+          test suite.</para>
+        </listitem>
         <listitem>
           <para>[xry111] - Update to JS-91.6.0.  Fixes

postlfs/security/polkit.xml

@@ -5 +5 @@
   %general-entities;
 
-  <!ENTITY polkit-download-http "https://www.freedesktop.org/software/polkit/releases/polkit-&polkit-version;.tar.gz">
+  <!ENTITY polkit-download-http "https://gitlab.freedesktop.org/polkit/polkit/-/archive/&polkit-version;/polkit-&polkit-version;.tar.gz">
   <!ENTITY polkit-download-ftp  " ">
-  <!ENTITY polkit-md5sum        "a6efe21d021fafe4191ee30331ef801c">
-  <!ENTITY polkit-size          "1.6 MB">
-  <!ENTITY polkit-buildsize     "12 MB">
-  <!ENTITY polkit-time          "0.1 SBU (Using parallelism=4)">
+  <!ENTITY polkit-md5sum        "5687b19e9ca9a0225957b8967d8f4458">
+  <!ENTITY polkit-size          "740 KB">
+  <!ENTITY polkit-buildsize     "8.9 MB (with tests)">
+  <!ENTITY polkit-time          "0.2 SBU (with tests, using parallelism=4)">
 ]>
 
@@ -218 +218 @@
 
 meson --prefix=/usr                       \
+      --buildtype=release                 \
       -Dman=true                          \
       -Dsession_tracking=libsystemd-login \
-      --buildtype=release                 \
+      -Dtests=true                        \
       ..                                  &amp;&amp;
 ninja</userinput></screen>
@@ -228 +229 @@
 
 meson --prefix=/usr                 \
+      --buildtype=release           \
       -Dman=true                    \
       -Dsession_tracking=libelogind \
       -Dsystemdsystemunitdir=/tmp   \
-      --buildtype=release           \
+      -Dtests=true   \
       ..                            &amp;&amp;
 ninja</userinput></screen>
 
-<!--
+    <!--
+      "-t3" for raising the timeout to 90s, i. e. 3x the default:
+      https://gitlab.freedesktop.org/polkit/polkit/-/merge_requests/107
+    -->
     <para>
       To test the results, first ensure that the system
       <application>D-Bus</application> daemon is running.
-      Then run <command>make check</command>.
-    </para>
--->
-
-<!-- The subprojects directory which contains a wrapper for 'mocklibc'
-     is not shipped in the tarball like it should be. Whenever that is
-     fixed, -Dtests=true and ninja test is the ticket. -->
-
-    <para>
-      This package does not ship with a working test suite.
+      Then run <command>meson test -t3</command>.
     </para>