Changeset 9612d4f3

Timestamp:

07/17/2024 10:04:10 AM (2 months ago)

Author:

Xi Ruoyao <xry111@…>

Branches:

12.2, gimp3, lazarus, trunk, xry111/for-12.3, xry111/spidermonkey128

Children:

4a17a25

Parents:

3d516cf

git-author:

Xi Ruoyao <xry111@…> (07/17/2024 10:01:21 AM)

git-committer:

Xi Ruoyao <xry111@…> (07/17/2024 10:04:10 AM)

Message:

tracker-miners: Fix test failures

There are several test failures caused by various issues. Apply two
patches from the upstream to fix 2 failures indicating real function
issues. Some tests expect LC_ALL=C.UTF-8. One test expects debug, so
run the test after installation and reconfiguration with debug enabled
like tracker.

Add a space after -D by the way.

File:

• gnome/platform/tracker3-miners.xml (modified) (11 diffs)

gnome/platform/tracker3-miners.xml

@@ -67 +67 @@
     </itemizedlist>
 
-<!--
     <bridgehead renderas="sect3">Additional Downloads</bridgehead>
     <itemizedlist spacing="compact">
@@ -77 +76 @@
       </listitem>
     </itemizedlist>
--->
 
     <bridgehead renderas="sect3">Tracker-miners Dependencies</bridgehead>
@@ -158 +156 @@
     </note>
 
-<!-- Applied in 3.6.2
-    <para>
-      First, fix some problems with the recent tightening of the seccomp
-      sandbox:
+    <para>
+      First, fix one issue in the TIFF extractor and another issue in the
+      Landlock sandbox:
     </para>
 
 <screen><userinput remap="pre">patch -Np1 -i ../tracker-miners-&tracker3-miners-version;-upstream_fixes-1.patch</userinput></screen>
--->
 
     <para>
@@ -178 +174 @@
 meson setup --prefix=/usr       \
             --buildtype=release \
-            -Dman=false         \
+            -D man=false        \
             ..                  &amp;&amp;
 ninja</userinput></screen>
@@ -185 +181 @@
 cd    build &amp;&amp;
 
-meson setup --prefix=/usr                 \
-            --buildtype=release           \
-            -Dsystemd_user_services=false \
-            -Dman=false                   \
-            ..                            &amp;&amp;
+meson setup --prefix=/usr                  \
+            --buildtype=release            \
+            -D systemd_user_services=false \
+            -D man=false                   \
+            ..                             &amp;&amp;
 ninja</userinput></screen>
 
-    <para>
-      <!-- tiff-photo-1 fails due to
-      https://gitlab.gnome.org/GNOME/tracker-miners/-/issues/341 -->
+
+    <para>
+      Now, as the <systemitem class="username">root</systemitem> user:
+    </para>
+
+    <screen role="root"><userinput>ninja install</userinput></screen>
+
+    <para>
       To test the results, issue (adjust the individual test timeout to a
       value suitable for your machine, see the note above):
     </para>
 
-<screen remap="test"><userinput>dbus-run-session env TRACKER_TESTS_AWAIT_TIMEOUT=<replaceable>20</replaceable> ninja test &amp;&amp;
+<screen remap="test"><userinput>meson configure -D debug=true &amp;&amp;
+dbus-run-session env LC_ALL=C.UTF-8 TRACKER_TESTS_AWAIT_TIMEOUT=<replaceable>20</replaceable> \
+                 ninja test &amp;&amp;
 rm -rf ~/tracker-tests</userinput></screen>
 
@@ -208 +211 @@
       </para>
     </note>
-
-    <para>
-      Now, as the <systemitem class="username">root</systemitem> user:
-    </para>
-
-<screen role="root"><userinput>ninja install</userinput></screen>
   </sect2>
 
@@ -223 +220 @@
 
     <para>
-      <parameter>-Dman=false</parameter>: This switch prevents the build process
+      <parameter>-D man=false</parameter>: This switch prevents the build process
       from generating man pages. Omit this switch if you have
       <xref linkend="asciidoc" role="nodep"/> installed and wish to generate and
@@ -230 +227 @@
 
     <para revision="sysv">
-      <parameter>-Dsystemd_user_services=false</parameter>: This switch prevents
+      <parameter>-D systemd_user_services=false</parameter>: This switch prevents
       the build process from installing systemd units since they are useless
       on SysV systems.
@@ -236 +233 @@
 
     <para>
-      <option>-Dseccomp=false</option>: This option disables the seccomp system
+      <option>-D seccomp=false</option>: This option disables the seccomp system
       call filter. On some architectures, such as i686 and ARM, the functions
       that tracker-miners uses are not guarded properly, and tracker-miners
@@ -246 +243 @@
 
     <para>
-      <option>-Dlandlock=disabled</option>: This switch disables the
+      <option>-D landlock=disabled</option>: This switch disables the
       Landlock file access sandbox.  Use it if you don't want to build the
       kernel with Landlock support.  Note that disabling Landlock might
@@ -254 +251 @@
 
     <para>
-      <option>-Dminer_rss=false</option>: Use this option if you have not
+      <option>-D miner_rss=false</option>: Use this option if you have not
       installed the recommended dependency libgrss.
     </para>
 
     <para>
-      <option>-Dbattery_detection=none</option>: Use this option if you have
+      <option>-D battery_detection=none</option>: Use this option if you have
       not installed the recommended dependency upower.  Do not use this
       option if your system has a battery (laptop battery or UPS), or