Changeset 96e0c171 for general/genlib

Timestamp:

11/19/2023 11:01:36 PM (6 months ago)

Author:

Xi Ruoyao <xry111@…>

Branches:

12.1, ken/TL2024, ken/tuningfonts, lazarus, plabs/newcss, python3.11, rahul/power-profiles-daemon, renodr/vulkan-addition, trunk, xry111/llvm18

Children:

331efa7

Parents:

9bfa685

Message:

mozilla: Drop SHELL=/bin/bash

Note that if you build something relying on $SHELL, it may still fail to
build in chroot.

In the chroot we first use "env -i" to clean the environment variables.
When bash starts with no $SHELL set, it *sets* SHELL=(the login shell
of current user specified in /etc/passwd), but it *does not export this
variable*.

For example:

$ cat > t.c << EOF
#include <stdio.h>
#include <stdlib.h>
int main() { puts (getenv ("SHELL") ?: "(nullptr)"); }
$ ./a.out
/bin/zsh/
$ cc t.c
$ env -i bash -c "echo $SHELL"
/bin/zsh
$ env -i bash -c "./a.out"
(nullptr)

We can remove this now only because Mozilla has added a workaround into
their building system at
​https://hg.mozilla.org/mozilla-central/rev/5afe7b911f61 for some Mac
builder, inadvertently fixing our issue.

Link: ​https://lists.linuxfromscratch.org/sympa/arc/blfs-support/2014-11/msg00050.html
Link: ​https://lists.linuxfromscratch.org/sympa/arc/blfs-dev/2023-11/msg00136.html

File:

• general/genlib/spidermonkey.xml (modified) (1 diff)

general/genlib/spidermonkey.xml

@@ -170 +170 @@
       <xi:include xmlns:xi="http://www.w3.org/2001/XInclude"
          href="../../xincludes/mozshm.xml"/>
-
-      <xi:include xmlns:xi="http://www.w3.org/2001/XInclude"
-         href="../../xincludes/mozconfigure.xml"/>
-
       <para>
         Compiling the C++ code respects $MAKEFLAGS and defaults to 'j1',