Changeset 97e7219

Timestamp:

01/18/2023 03:16:10 AM (15 months ago)

Author:

Xi Ruoyao <xry111@…>

Branches:

11.3, 12.0, 12.1, kea, ken/TL2024, ken/inkscape-core-mods, ken/tuningfonts, lazarus, lxqt, plabs/newcss, plabs/python-mods, python3.11, qt5new, rahul/power-profiles-daemon, renodr/vulkan-addition, trunk, xry111/llvm18, xry111/xf86-video-removal

Children:

0f9a1f08, 4fe5cec

Parents:

aa5add9

git-author:

Xi Ruoyao <xry111@…> (01/18/2023 03:07:48 AM)

git-committer:

Xi Ruoyao <xry111@…> (01/18/2023 03:16:10 AM)

Message:

rust: revise config.toml entries (#17520)

• Add locked-deps = true and vendor = true. These allows building the package w/o downloading from crates.io (the bootstrap compiler still needs to be downloaded though), and eliminates the necessity of using a DESTDIR installation. Note that in LFS we already do DESTDIR installation for ncurses so we won't lose too much educational material.
• Add description = "for BLFS &version;" so BLFS version will show up in the output of rustc --version.
• Remove rpath = false. With rpath we can skip the modification of /etc/ld.so.conf file. Note that rpath is coded as $ORIGIN/../lib, so if you run ldd on the executable in the build directory, it will show the path to the build directory; but if you run ldd on the installed executable, it will show the correct path to the installed library. See man ld.so for more information about $ORIGIN.

File:

• general/prog/rust.xml (modified) (14 diffs)

general/prog/rust.xml

@@ -9 +9 @@
   <!ENTITY rust-md5sum        "96b082a8b44707eafa9d696923f40c28">
   <!ENTITY rust-size          "136 MB">
-  <!-- Gentle Reminder: buildsize is how much the user requires for the real
-       install, i.e. the source with its DESTDIR *plus* the DESTDIR.  You
-       can 'mkdir /tmp/RUST ; cp -a install/* /tmp/RUST' and then run 'du -sch'
-       to measure it, or du -sm to look at the size of the build tree before and
-       after the tests. -->
-
-  <!ENTITY rust-buildsize     "9.4 GB (674 MB installed) including 360 MB of ~/.cargo files for the user building this. Add 6.5 GB including extra 312 MB of ~/.cargo files if running the tests">
+  <!ENTITY rust-buildsize     "9.1 GB (323 MB installed); add 6.2 GB if running the tests">
   <!ENTITY rust-time          "17 SBU (including download time; add 23 SBU for tests, both on a 4-core machine)">
 ]>
@@ -47 +41 @@
     <para>
       As with many  other programming languages, rustc (the rust compiler)
-      needs a binary from which to bootstrap. It will download a stage0 binary
-      and many cargo crates (these are actually .tar.gz source archives) at
-      the start of the build, so you cannot compile it without an internet
-      connection.
-    </para>
-
-    <para>
-      These crates will then remain in various forms (cache, directories of
-      extracted source), in <filename class="directory">~/.cargo</filename> for
-      ever more. It is common for large <application>rust</application> packages
-      to use multiple versions of some crates. If you purge the files before
-      updating this package, very few crates will need to be updated by the
-      packages in this book which use it (and they will be downloaded as
-      required). But if you retain an older version as a fallback option and
-      then use it (when <emphasis>not</emphasis> building in
-      <filename class="directory">/usr</filename>), it is likely that it will
-      then have to re-download some crates. For a full download (i.e. starting
-      with an empty or missing <filename class="directory">~/.cargo</filename>)
-      downloading the external cargo files for this version only takes a minute
-      or so on a fast network.
+      needs a binary from which to bootstrap. It will download a stage0
+      binary at the start of the build, so you cannot compile it without an
+      Internet connection.
     </para>
 
@@ -89 +66 @@
       <para>
         If you prefer, you can of course change the prefix to <filename
-        class="directory">/usr</filename> and omit the
-        <command>ldconfig</command> and the actions to add rustc to the PATH.
+        class="directory">/usr</filename>.
       </para>
     </note>
@@ -138 +114 @@
         often reasonably consistent, but as with all compilations using
         <command>rustc</command> there can be some very slow outliers.
-      </para>
-      <para>
-        Unusually, a DESTDIR-style method is being used to install this package.
-        This is because running the install as root not only downloads all of the
-        cargo files again (to <filename>/root/.cargo</filename>), it then spends
-        a very long time recompiling. Using this method saves a lot of time, at
-        the cost of extra disk space.
       </para>
     </note>
@@ -305 +274 @@
 extended = true
 
+# Do not query new versions of dependencies online.
+locked-deps = true
+
 # Specify which extended tools (those from the default install).
 tools = ["cargo", "clippy", "rustfmt"]
+
+# Use the source code shipped in the tarball for the dependencies.
+# The combination of this and the "locked-deps" entry avoids downloading
+# many crates from Internet, and makes the Rustc build more stable.
+vendor = true
 
 [install]
@@ -314 +291 @@
 [rust]
 channel = "stable"
-rpath = false
+description = "for BLFS &version;"
 
 # BLFS used to not install the FileCheck executable from llvm,
@@ -370 +347 @@
     </para>
 
-<screen remap="test"><userinput>export LD_LIBRARY_PATH=$PWD/build/x86_64-unknown-linux-gnu/stage1/lib/ &amp;&amp;
-python3 ./x.py test --verbose --no-fail-fast | tee rustc-testlog
-unset LD_LIBRARY_PATH</userinput></screen>
+<screen remap="test"><userinput>python3 ./x.py test --verbose --no-fail-fast | tee rustc-testlog</userinput></screen>
 
     <para>
@@ -417 +392 @@
 
     <para>
-      Still as your normal user, do a DESTDIR install:
-    </para>
-
-<screen><userinput>DESTDIR=${PWD}/install python3 ./x.py install &amp;&amp;</userinput></screen>
-
-    <para>
-      Now, as the <systemitem class="username">root</systemitem> user
-      install the files from the DESTDIR:
-    </para>
-
-<screen role="root"><userinput>chown -R root:root install &amp;&amp;
-cp -a install/* /</userinput></screen>
+      Now, as the &root; user, install the package:
+    </para>
+
+<screen role='root'><userinput>python3 ./x.py install</userinput></screen>
 
   </sect2>
@@ -444 +411 @@
     <para>
       <command>targets = "X86"</command>: this avoids building all the available
-      linux cross-compilers (Aarch64, MIPS, PowerPC, SystemZ, etc). Unfortunately,
+      linux cross-compilers (AArch64, MIPS, PowerPC, SystemZ, etc). Unfortunately,
       rust insists on installing source files for these below
       <filename class="directory">/opt/rustc/lib/src</filename>.
@@ -450 +417 @@
 
     <para>
-      <command>extended = true</command>: this installs Cargo alongside Rust.
+      <command>extended = true</command>: this installs several tools
+      (specified by the <literal>tools</literal> entry) alongside
+      <command>rustc</command>.
     </para>
 
@@ -470 +439 @@
     </para>
 
-    <para>
-      <command>rpath = false</command>: by default, <command>rust</command> can
-      be run from where it was built, without being installed. That adds DT_RPATH
-      entries to all of the ELF files, which produces very messy output from
-      <command>ldd</command>, showing the libraries in the place they were built,
-      even if they have been deleted from there after the install.
-    </para>
-
     <!-- comment while using shipped LLVM -->
     <para>
@@ -513 +474 @@
 
     <para>
-      <command>export LD_LIBRARY_PATH=$PWD/build/x86_64-unknown-linux-gnu/stage1/lib/</command>:
-      In builds where rpath is enabled, the stage1 libraries can be used by the
-      tests. But BLFS has disabled rpath: this environment variable allows a lot
-      more tests to run. Without it there are no reported failures in most runs,
-      but some odd messages in the test log implying failures.
-    </para>
-
-    <para>
       <command>--verbose</command>: this switch can sometimes provide more
       information about a test which fails.
@@ -528 +481 @@
       <command>--no-fail-fast</command>: this switch ensures that the test suite
       will not stop at the first error.
-    </para>
-
-    <para>
-      <command>DESTDIR=${PWD}/install python3 ./x.py install</command>: This
-      effects a DESTDIR-style install in the source tree,creating an <filename
-      class="directory">install</filename> directory. Note that DESTDIR installs
-      need an absolute path, passing 'install' will not work.
-    </para>
-
-    <para>
-      <command>chown -R root:root install</command>: the DESTDIR install
-      was run by a regular user, who owns the files. For security, change their
-      owner before doing a simple copy to install them.
     </para>
 
@@ -557 +497 @@
         is correctly found by other packages and system processes.
       </para>
-
-      <para>
-        As the <systemitem class="username">root</systemitem> user, update
-        the <filename>/etc/ld.so.conf</filename> file and the dynamic linker's
-        run-time cache file:
-      </para>
-
-<screen role="root"><userinput>cat &gt;&gt; /etc/ld.so.conf &lt;&lt; EOF
-<literal># Begin rustc addition
-
-/opt/rustc/lib
-
-# End rustc addition</literal>
-EOF
-
-ldconfig</userinput></screen>
-
-      <indexterm zone="rust rustc-config">
-        <primary sortas="e-etc-ld.so.conf">/etc/ld.so.conf</primary>
-      </indexterm>
 
       <para>