Changeset 9d98701

Timestamp:

05/15/2023 07:21:23 AM (12 months ago)

Author:

Xi Ruoyao <xry111@…>

Branches:

12.0, 12.1, kea, ken/TL2024, ken/tuningfonts, lazarus, lxqt, plabs/newcss, python3.11, rahul/power-profiles-daemon, renodr/vulkan-addition, trunk, xry111/llvm18, xry111/xf86-video-removal

Children:

bee906c

Parents:

3f6a6dc

Message:

firefox: Use the same patch as Thunderbird

Firefox shares many components with TB, so it also suffers the
same mutability UB exploited by LLVM 16. Though it does not crash at
start up, there are some reports saying a crash will happen in certain
conditions. Use the same patch as TB to fix the UB.

The patch has been symlinked in patches.git.

File:

• xsoft/graphweb/firefox.xml (modified) (2 diffs)

xsoft/graphweb/firefox.xml

@@ -80 +80 @@
         <para>
           Required patch:
-          <ulink url="&patch-root;/firefox-&firefox-version;-upstream_fixes-1.patch"/>
+          <ulink url="&patch-root;/firefox-&firefox-version;-consolidated-1.patch"/>
         </para>
       </listitem>
@@ -353 +353 @@
 
     </note>
-    <para>
-      First ensure that some headers moved out of the C++ standard library in
-      GCC-13 are included:
-    </para>
-
-<screen><userinput>sed -e '/#include &lt;cmath&gt;/a#include &lt;cstdint&gt;' -i gfx/2d/Rect.h
-sed -e '/#include &lt;string&gt;/a#include &lt;cstdint&gt;' \
- -i dom/media/webrtc/sdp/RsdparsaSdpGlue.cpp
-sed -e '/#include &lt;cstdlib&gt;/a#include &lt;cstdint&gt;' \
- -i toolkit/components/telemetry/pingsender/pingsender.cpp
-</userinput></screen>
-
-    <para>
-      Fix a build failure that occurs due to the rust-bindgen crate being
-      incompatible with LLVM-16:
-    </para>
-
-<screen><userinput remap="pre">patch -Np1 -i ../firefox-&firefox-version;-upstream_fixes-1.patch</userinput></screen>
+
+    <para>
+      Fix building Firefox with Clang 16 or C++ headers from GCC 13.
+      And, work around a crash caused by an undefined behavior in the Rust
+      FFI code which is exploited by Rustc using LLVM 16 as the backend:
+    </para>
+
+<screen><userinput remap="pre">patch -Np1 -i ../firefox-&firefox-version;-consolidated-1.patch</userinput></screen>
 
     <para>