Changeset ae27cdc

Timestamp:

11/16/2022 04:15:52 PM (18 months ago)

Author:

Pierre Labastie <pierre.labastie@…>

Branches:

11.3, 12.0, 12.1, kea, ken/TL2024, ken/inkscape-core-mods, ken/tuningfonts, lazarus, lxqt, plabs/newcss, plabs/python-mods, python3.11, qt5new, rahul/power-profiles-daemon, renodr/vulkan-addition, trunk, xry111/llvm18, xry111/xf86-video-removal

Children:

3619a5b9

Parents:

4635a45d

git-author:

Pierre Labastie <pierre.labastie@…> (11/16/2022 03:42:25 PM)

git-committer:

Pierre Labastie <pierre.labastie@…> (11/16/2022 04:15:52 PM)

Message:

shadow: don't use <cond> && <cmd> for conditional

Explain why in a comment.

File:

• postlfs/security/shadow.xml (modified) (2 diffs)

postlfs/security/shadow.xml

@@ -558 +558 @@
           <primary sortas="e-etc-security-access.conf">/etc/security/access.conf</primary>
         </indexterm>
-
-<screen role="root"><userinput>[ -f /etc/login.access ] &amp;&amp; mv -v /etc/login.access{,.NOUSE}</userinput></screen>
+<!-- to editors: it is a common belief that:
+        if <condition>; then <command>; fi
+     is equivalent to:
+        <condition> && <command>
+     This is not true in bash; try:
+        ([ 0 = 1 ] && echo not reachable); echo $? # echoes 1
+     vs
+        (if [ 0 = 1 ]; then echo not reachable; fi); echo $? # echoes 0
+     So in scripts that may call subshells (for example through sudo) and
+     that need error reporting, the outcome _is_ different. In all
+     cases, for bash, the "if" form should be preferred.-->
+<screen role="root"><userinput>if [ -f /etc/login.access ]; then mv -v /etc/login.access{,.NOUSE}; fi</userinput></screen>
       </sect4>
 
@@ -578 +588 @@
         </indexterm>
 
-<screen role="root"><userinput>[ -f /etc/limits ] &amp;&amp; mv -v /etc/limits{,.NOUSE}</userinput></screen>
+<screen role="root"><userinput>if [ -f /etc/limits ]; then mv -v /etc/limits{,.NOUSE}; fi</userinput></screen>
 
         <caution>