Changeset c025978

Timestamp:

07/19/2024 09:42:28 AM (7 weeks ago)

Author:

Xi Ruoyao <xry111@…>

Branches:

12.2, lazarus, trunk, xry111/for-12.3, xry111/spidermonkey128

Children:

470ac26

Parents:

0c34633

git-author:

Xi Ruoyao <xry111@…> (07/19/2024 09:32:19 AM)

git-committer:

Xi Ruoyao <xry111@…> (07/19/2024 09:42:28 AM)

Message:

firefox, thunderbird: Enable rust SIMD again

The shipped encoding_rs crate has been ported from the broken
packed_simd to portable_simd. The latter is still a nightly feature but
the building system has some internal magic to enable nightly features
for our stable rustc build.

The danger of using nightly feature is it'll be more likely to be broken
with the future rustc releases. But we can then revert this change if
it happens anyway.

Location:

xsoft

Files:

• graphweb/firefox.xml (modified) (1 diff)
• other/thunderbird.xml (modified) (1 diff)

xsoft/graphweb/firefox.xml

@@ -254 +254 @@
 ac_add_options --disable-tests
 
-# The SIMD code relies on the unmaintained packed_simd crate which
-# fails to build with Rustc >= 1.78.0.  We may re-enable it once
-# Mozilla port the code to use std::simd and std::simd is stabilized.
-ac_add_options --disable-rust-simd
+# This enables SIMD optimization in the shipped encoding_rs crate.
+ac_add_options --enable-rust-simd
 
 ac_add_options --enable-system-ffi

xsoft/other/thunderbird.xml

@@ -216 +216 @@
 ac_add_options --disable-tests
 
-# The SIMD code relies on the unmaintained packed_simd crate which
-# fails to build with Rustc >= 1.78.0.  We may re-enable it once
-# Mozilla port the code to use std::simd and std::simd is stabilized.
-ac_add_options --disable-rust-simd
+# This enables SIMD optimization in the shipped encoding_rs crate.
+ac_add_options --enable-rust-simd
 
 ac_add_options --enable-strip