Changeset dcf0bcc2 for multimedia/libdriv

Timestamp:

12/22/2023 07:38:13 PM (6 months ago)

Author:

Xi Ruoyao <xry111@…>

Branches:

12.1, ken/TL2024, lazarus, plabs/newcss, python3.11, rahul/power-profiles-daemon, trunk, xry111/llvm18

Children:

7b63cb6e

Parents:

b9d313c

Message:

liba52: Use -fPIC even on 32-bit x86

See the updated command explanation for rationale of this change. And
it also makes the instruction simpler, so it's a win-win.

File:

• multimedia/libdriv/liba52.xml (modified) (2 diffs)

multimedia/libdriv/liba52.xml

@@ -92 +92 @@
             --enable-shared         \
             --disable-static        \
-            CFLAGS="${CFLAGS:--g -O3} $([ $(uname -m) = x86_64 ] && echo -fPIC)" &&
+            CFLAGS="${CFLAGS:--g -O3} -fPIC" &&
 make</userinput></screen>
 
@@ -114 +114 @@
 
     <para>
-      <parameter>CFLAGS="${CFLAGS:--g -O3} ...</parameter>: This sets
-      CFLAGS to -g -O3
-      (which is the default) but then on x86_64 adds -fPIC. This is needed to
-      compile <application>liba52</application> on x86_64.
+      <parameter>CFLAGS="${CFLAGS:--g -O3} -fPIC"</parameter>: This appends
+      <option>-fPIC</option> to <envar>CFLAGS</envar> but use
+      <option>-g -O3</option> (the default of this package) instead of an
+      empty string when <envar>CFLAGS</envar> is not set.
+      This is needed to compile <application>liba52</application> without
+      runtime text relocation.  Runtime text relocation is prohibited on
+      x86_64 so <option>-fPIC</option> is strictly required.  On 32-bit x86
+      runtime text relocation is allowed but it's insecure and it may waste
+      physical RAM, so <option>-fPIC</option> is still better.
     </para>