Changes between Initial Version and Version 1 of Ticket #19637


Ignore:
Timestamp:
04/10/2024 10:50:53 AM (12 months ago)
Author:
Xi Ruoyao
Comment:

Reword the description to match the recent upstream analysis.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #19637

    • Property Summary Patch pipewire to support snapshot with gstreamer-1.24 → Fix pipewire to unbreak snapshot

  • TabularUnified Ticket #19637 – Description

    initial v1  
    1 After a very difficult debugging session, I found this commit is needed for snapshot to work with gstreamer-1.24:
     1A bug in pipewire is breaking snapshot for me:
    22
    3 https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/f1b75fc6f803f866d2ed0f7d1366f56ef96f0610
     3https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/3959
    44
    5 But this commit is a part of https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/1881, this MR includes another change:
     5The upstream has committed a fix for it:
    66
    7 https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/8a271a87b77e4508bb698f9b9e9fe3624884bfa6
    8 
    9 and this change immediately breaks snapshot again.  It's then fixed by:
    10 
    11 https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/1a6bb994a502d95434e326a35a83a1fb5f4ebad8
    12 
    13 Navigating through the log of the master branch, there are other two commits "fixing" `f1b75fc6f803f866d2ed0f7d1366f56ef96f0610`:
    14 
    15 https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/8848c7e7920618b97016243912bcb20c69a71960
    16 
    17 and
    18 
    19 https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/cc0f7596d6513a2fd9829548bbbf9b40120007a2
    20 
    21 I plan to add all these 5 patches to pipewire.
     7https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/b5284791fc414b2355bbb738a49bd8193a14c447