Changes between Initial Version and Version 1 of Ticket #19741, comment 3


Ignore:
Timestamp:
05/02/2024 07:24:54 AM (6 weeks ago)
Author:
martyj19

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #19741, comment 3

    initial v1  
    11Remove some GooString methods, use std::string ones instead would be great except for the fact that some of them are only in C++20 and fail the build in some users of poppler.  The attached patch may be of assistance.  How poppler upstream decides to deal with this may be different.
     2
     3The patch fixes non C++20 builds that don't use these methods.  Non C++20 builds that do use these methods are already broken by the poppler change unless they are able to go to C++20 for their whole project.
     4
     5I think the only true fix is revert the poppler change (which would put the old implementation back).