libgtop-2.30.0

[Fernando de Oliveira]

​http://ftp.gnome.org/pub/gnome/sources/libgtop/2.30/libgtop-2.30.0.tar.xz

​http://ftp.gnome.org/pub/gnome/sources/libgtop/2.30/libgtop-2.30.0.news

28 April 2014: Pvervoew pf cjamges om 2.30.0
=============================================
* Fixed libtool versioning for ABI breakage.
* Removed useless override for LINK variable.
* Fixed FTBFS on kFreeBSD.

[Fernando de Oliveira]

It is the same with other packages.

I try "make check" and it works but seems to do nothing:

Making check in po
make[1]: Entering directory '/home/fernando/tmp/paco-build-2014.05.01-09h28m03s/libgtop-2.30.0/po'
INTLTOOL_EXTRACT="/usr/bin/intltool-extract" XGETTEXT="/usr/bin/xgettext" srcdir=. /usr/bin/intltool-update --gettext-package libgtop-2.0 --pot
rm -f missing notexist
srcdir=. /usr/bin/intltool-update -m
if [ -r missing -o -r notexist ]; then \
  exit 1; \
fi
make[1]: Leaving directory '/home/fernando/tmp/paco-build-2014.05.01-09h28m03s/libgtop-2.30.0/po'
Making check in misc
make[1]: Entering directory '/home/fernando/tmp/paco-build-2014.05.01-09h28m03s/libgtop-2.30.0/misc'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/fernando/tmp/paco-build-2014.05.01-09h28m03s/libgtop-2.30.0/misc'
Making check in include
...

It goes through other directories, and always there is a message "Nothing to be done for 'check'"

Does this means that make check succeeded, or that there is not any check at all?

[ken@…]

(replying to comment 2 - I can't trim that down if I use the Reply option).

This is fairly common, patricularly in gnome packages. In this case, intltool-update is run, which can generate new po files, and make check will exit if the missing or notexist files exist. So, that is a packaging check to run before a tarball is released, not a test for users.

If every directory except po reports Nothing to be done for 'check' then there are no tests for users/builders to run.

For a test suite which runs but only reports there is nothing to be done, I normally say "This package does not have a testsuite." In this case, I would say (copying from my local copybook, with a comment for when I would use it - the book doesn't need the comment) :

    # only checking xml of the translations, or checking the translations
    # get used
    <para>This package&apos;s testsuite is only intended to be used by the
    maintainer to check i18n files.</para>

FWIW, sometimes a package has a similar intltool test which fails. For those, I am always tempted to put:

    <para>This package&apos;s testsuite is intended to be used by the
    maintainer (or not) to check i18n files.</para>

[Fernando de Oliveira]

LOL.

Thanks, ĸen.

Good to learn that.

I will leave as is, then.

[Fernando de Oliveira]

Thanks, ĸen.

Fixed at r13016.