Opened 6 years ago

Closed 6 years ago

#7596 closed enhancement (fixed)

poppler-0.42.0

Reported by: bdubbs@… Owned by: bdubbs@…
Priority: normal Milestone: 7.10
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description

New minor version

Change History (4)

comment:1 by ken@…, 6 years ago

Fernando says that the testsuite does still exist in 41 (my notes say there was nothing to be done for check), so I don't think I'm competent to touch this package in future. Fortunately, I only commented out the details.

in reply to:  1 comment:2 by Fernando de Oliveira, 6 years ago

Replying to ken@…:

[Limited the citation to 72 characters - when I was creating the tickets, I used to do it as much as possible, because I know your difficulty with long lines]

Fernando says that the testsuite does still exist in 41 (my notes say there was nothing to be done for check), so I don't think I'm competent to touch this package in future. Fortunately, I only commented out the details.

I am not only saying, but proving.

BTW, the test suite *works with -jN* (1 ≤ N ≤ cpu X threads).

I find

$ xzgrep -E 'Making check|Nothing to be done' \
  poppler-0.41.0-make-k-check-2016.03.17-11h11m26s.log.xz
Making check in goo
make[1]: Nothing to be done for 'check'.
Making check in fofi
make[1]: Nothing to be done for 'check'.
Making check in splash
make[1]: Nothing to be done for 'check'.
Making check in poppler
Making check in utils
make[1]: Nothing to be done for 'check'.
Making check in glib
Making check in .
Making check in reference
make[3]: Nothing to be done for 'check'.
Making check in demo
make[3]: Nothing to be done for 'check'.
Making check in test
make[1]: Nothing to be done for 'check'.
Making check in qt4
Making check in src
make[3]: Nothing to be done for 'check-am'.
Making check in tests
Making check in demos
make[3]: Nothing to be done for 'check-am'.
make[2]: Nothing to be done for 'check-am'.
Making check in qt5
Making check in src
make[3]: Nothing to be done for 'check-am'.
Making check in tests
Making check in demos
make[3]: Nothing to be done for 'check-am'.
make[2]: Nothing to be done for 'check-am'.
Making check in cpp
Making check in .
make[2]: Nothing to be done for 'check-am'.
Making check in tests
make[2]: Nothing to be done for 'check'.

Finally tests finishes, record statistics and grep to have the results (double, due to tests with Qt4 and 5) repeated in on place at the end:

...

make[1]: Leaving directory '/tmp/porg-build-2016.03.17-11h11m26s/poppler-0.41.0'

real 0m54.176s
user 0m47.248s
sys 0m5.211s

11M ../DEST-poppler-0.41.0
54M ../poppler-0.41.0
65M total

Testsuite summary for poppler 0.41.0
============================================================================
# TOTAL: 16
# PASS: 16
# SKIP: 0
# XFAIL: 0
# FAIL: 0
# XPASS: 0
# ERROR: 0
============================================================================
--
Testsuite summary for poppler 0.41.0
============================================================================
# TOTAL: 16
# PASS: 16
# SKIP: 0
# XFAIL: 0
# FAIL: 0
# XPASS: 0
# ERROR: 0
============================================================================

Is your intention to remove all test suites? This could be discussed. But removing the test suite from poppler without any discussion?

I think we give too much emphasis to many test suites, rather than testing whether a package for which something is a dependency still works. But I commented the text becasue it seemed to me that there was no longer a testsuite.

OK.

As I said somewhere, I could accept a decision to remove all test suites, although, many has helped me, many are a PITA.

But as you see there are tests.

The same way as many other packages, test suites or related harness or data must be additionally downloaded:

OpenJDK (tarball from anduin). FFmpeg (rsync) Lua (tarball from mainstream)

I my have missed some.

And I have already run for version 0.42.0. Results have been similar for many editions.

Attaching the full make-check logs for the ticket #7474

<http://wiki.linuxfromscratch.org/blfs/ticket/7474>

poppler-0.41.0-make-k-check-2016.03.17-11h11m26s.log.xz

and

for the ticket #7596

<http://wiki.linuxfromscratch.org/blfs/ticket/7596>

poppler-0.42.0-make-k-check-2016.03.17-11h05m22s.log.xz

comment:3 by bdubbs@…, 6 years ago

Owner: changed from blfs-book@… to bdubbs@…
Status: newassigned

comment:4 by bdubbs@…, 6 years ago

Resolution: fixed
Status: assignedclosed

Fixed at revision 17174.

Note: See TracTickets for help on using tickets.