Changeset 908a3c3

Timestamp:

07/20/2021 10:24:26 AM (3 years ago)

Author:

Xi Ruoyao <xry111@…>

Branches:

11.0, 11.0-rc1, 11.0-rc2, 11.0-rc3, 11.1, 11.1-rc1, 11.2, 11.2-rc1, 11.3, 11.3-rc1, 12.0, 12.0-rc1, 12.1, 12.1-rc1, arm, bdubbs/gcc13, ml-11.0, multilib, renodr/libudev-from-systemd, s6-init, trunk, xry111/arm64, xry111/arm64-12.0, xry111/clfs-ng, xry111/lfs-next, xry111/loongarch, xry111/loongarch-12.0, xry111/loongarch-12.1, xry111/mips64el, xry111/pip3, xry111/rust-wip-20221008, xry111/update-glibc

Children:

7ea60d3

Parents:

14e0b47 (diff), 94862da (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'xry111/tester-nohack' into trunk

Use a fixed UID for "tester" user, instead of the tty owner's UID.

The problem using tty owner's UID is, when tty is owned by "root" the
UID of "tester" will be 0. This cause a namesis between "tester" and
root. And, the "tester" is introduced to run some tests which are not
expected to be ran as root. If "tester" has UID 0, it will have root
priviledge and the tests will fail again.

Bash tests require the user to own the tty. To satisify it, we use
Expect to spawn a new pseudoterminal to run Bash tests.

Files:

• appendices/dependencies.xml (modified) (1 diff)
• chapter07/createfiles.xml (modified) (1 diff)
• chapter08/bash.xml (modified) (1 diff)

appendices/dependencies.xml

@@ -219 +219 @@
         <segtitle>&testsuites;</segtitle>
         <seglistitem>
-          <seg>Shadow</seg>
+          <seg>Expect and Shadow</seg>
         </seglistitem>
       </segmentedlist>

chapter07/createfiles.xml

@@ -176 +176 @@
   chapter.</para>
 
-<screen><userinput>echo "tester:x:$(ls -n $(tty) | cut -d" " -f3):101::/home/tester:/bin/bash" &gt;&gt; /etc/passwd
+<screen><userinput>echo "tester:x:101:101::/home/tester:/bin/bash" &gt;&gt; /etc/passwd
 echo "tester:x:101:" &gt;&gt; /etc/group
 install -o tester -d /home/tester</userinput></screen>

chapter08/bash.xml

@@ -74 +74 @@
 <screen><userinput remap="test">chown -Rv tester .</userinput></screen>
 
-    <para>Now, run the tests as the <systemitem
+    <para>The testsuite of the package is designed to be ran as a non-root
+    user, owning the terminal connected to standard input.  To satisify the
+    requirement, spawn a new pseudoterminal using
+    <application>Expect</application> and run the tests as the <systemitem
     class="username">tester</systemitem> user:</para>
 
-<screen><userinput remap="test">su tester &lt;&lt; EOF
-PATH=$PATH make tests &lt; $(tty)
+<screen><userinput remap="test">su -s /usr/bin/expect tester &lt;&lt; EOF
+set timeout -1
+spawn make tests
+expect eof
+lassign [wait] _ _ _ value
+exit $value
 EOF</userinput></screen>