id	summary	reporter	owner	description	type	status	priority	milestone	component	version	severity	resolution	keywords	cc
2199	Making the LFS book from SVN 8551 failed for me	Gunter Liszewski	lfs-book@…	"=== Proposed Changes ===

{{{
Making the LFS  failed for me. To fix the problem I corrected a typo in process-scripts.sh.
'=' is the correct string comparison operator.

I also replaced 'sh' with 'bash' in the Makefile, because an error during the make reported
that 'popd', and 'pushd' are not available while running in the 'sh' shell.

--This line, and those below, will be ignored--

M    process-scripts.sh
M    Makefile
}}}

=== svn diff ===

{{{
Index: process-scripts.sh
===================================================================
--- process-scripts.sh	(revision 8551)
+++ process-scripts.sh	(working copy)
@@ -1,4 +1,4 @@
-#!/bin/sh
+ #!/bin/sh
 
 # Boot scripts
 for s in bootscripts/lfs/init.d/*                    \
@@ -9,12 +9,12 @@
   script=$(basename $s)
   
   # Skip directories
-  [ $script == 'network-devices' ] && continue
-  [ $script == 'services'        ] && continue
+  [ $script = 'network-devices' ] && continue
+  [ $script = 'services'        ] && continue
 
   # Disambiguate duplicate file names
-  [ $s == 'bootscripts/lfs/sysconfig/rc'      ] && script='rc-sysinit'; 
-  [ $s == 'bootscripts/lfs/sysconfig/modules' ] && script='modules-sysinit'; 
+  [ $s = 'bootscripts/lfs/sysconfig/rc'      ] && script='rc-sysinit'; 
+  [ $s = 'bootscripts/lfs/sysconfig/modules' ] && script='modules-sysinit'; 
   
   sed  -e 's/\&/\&amp\;/g' -e 's/</\&lt\;/g'   -e 's/>/\&gt\;/g' \
        -e ""s/'/\&apos\;/g"" -e 's/""/\&quot\;/g' -e 's/\t/    /g'  \
Index: Makefile
===================================================================
--- Makefile	(revision 8551)
+++ Makefile	(working copy)
@@ -84,7 +84,7 @@
 	$(Q)xmllint --nonet --noent --xinclude --postvalid \
 	  -o $(RENDERTMP)/lfs-full.xml index.xml
 	$(Q)rm -f appendices/*.script
-	$(Q)sh aux-file-data.sh $(RENDERTMP)/lfs-full.xml
+	$(Q)bash aux-file-data.sh $(RENDERTMP)/lfs-full.xml
 
 maketar:
 	@echo ""Making tarballs...""

}}}"	defect	new	normal		Book	SVN	normal