id	summary	reporter	owner	description	type	status	priority	milestone	component	version	severity	resolution	keywords	cc
4339	Wrong input for wget-list in Makefile	thomas	lfs-book	"In the Makefile there is the section

{{{
wget-list: $(BASEDIR)/wget-list
$(BASEDIR)/wget-list: stylesheets/wget-list.xsl chapter03/chapter03.xml \
                      packages.ent patches.ent
        @echo ""Generating consolidated wget list at $(BASEDIR)/wget-list ...""
        $(Q)mkdir -p $(BASEDIR)

        $(Q)xsltproc --nonet --xinclude                    \
                --stringparam profile.revision $(REV) \
                --output $(RENDERTMP)/sysd-wget.xml   \
                stylesheets/lfs-xsl/profile.xsl       \
                chapter03/chapter03.xml

        $(Q)xsltproc --xinclude --nonet            \
                --output $(BASEDIR)/wget-list \
                     stylesheets/wget-list.xsl     \
                chapter03/chapter03.xml
}}}

shouldn't the last xslproc use ""sysd-wget.xml"" as input? It would than read as:

{{{
wget-list: $(BASEDIR)/wget-list
$(BASEDIR)/wget-list: stylesheets/wget-list.xsl chapter03/chapter03.xml \
                      packages.ent patches.ent
        @echo ""Generating consolidated wget list at $(BASEDIR)/wget-list ...""
        $(Q)mkdir -p $(BASEDIR)

        $(Q)xsltproc --nonet --xinclude                    \
                --stringparam profile.revision $(REV) \
                --output $(RENDERTMP)/sysd-wget.xml   \
                stylesheets/lfs-xsl/profile.xsl       \
                chapter03/chapter03.xml

        $(Q)xsltproc --xinclude --nonet            \
                --output $(BASEDIR)/wget-list \
                     stylesheets/wget-list.xsl     \
                $(RENDERTMP)/sysd-wget.xml
}}}

A patch would look like:

{{{
--- Makefile.orig	2018-08-20 14:05:17.206025624 +0200
+++ Makefile	2018-08-20 14:05:55.919230588 +0200
@@ -167,7 +167,7 @@
 	$(Q)xsltproc --xinclude --nonet            \
                 --output $(BASEDIR)/wget-list \
 	             stylesheets/wget-list.xsl     \
-                chapter03/chapter03.xml
+                $(RENDERTMP)/sysd-wget.xml
 
 md5sums: $(BASEDIR)/md5sums
 $(BASEDIR)/md5sums: stylesheets/wget-list.xsl chapter03/chapter03.xml \
}}}"	defect	closed	low	8.3	Book	SVN	minor	fixed