Opened 5 years ago

Closed 5 years ago

#1720 closed defect (fixed)

unset MAKELEVEL in scriptlets

Reported by: Pierre Labastie Owned by: Pierre Labastie
Priority: normal Milestone: 3.0
Component: jhalfs Version: SVN
Severity: normal Keywords:
Cc:

Description

jhalfs (and blfs extension) run scriptlets from a Makefile, so that MAKELEVEL=1 when starting "make" in a build directory. This can lead to weird errors, as explained in postgresql INSTALL file:

If you want to invoke the build from another makefile rather than
       manually, you must unset MAKELEVEL or set it to zero, for instance
       like this:
build-postgresql:
        $(MAKE) -C postgresql MAKELEVEL=0 all

       Failure to do that can lead to strange error messages, typically
       about missing header files.

Change History (3)

comment:1 by Pierre Labastie, 5 years ago

I guess MAKELEVEL=1 is harmless in most cases, but for the few cases it is not (postgresql is one such case), we should unset MAKELEVEL (or set it to 0) in the generated scriptlets.

comment:2 by Pierre Labastie, 5 years ago

Owner: changed from alfs-log@… to Pierre Labastie
Status: newassigned

comment:3 by Pierre Labastie, 5 years ago

Resolution: fixed
Status: assignedclosed

Fixed at r4088

Note: See TracTickets for help on using tickets.