Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#4077 closed enhancement (fixed)

tcl/tk-8.6.1

Reported by: bdubbs@… Owned by: Fernando de Oliveira
Priority: normal Milestone:
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description

New point version for both packages

Change History (12)

comment:1 by Fernando de Oliveira, 11 years ago

I was trying to update these packages. They build, install and work fine, at least for the package I need tk.

Tests are fine for tcl, but for tk, many have failed and the last one hangs untill I close by hand the window with two buttons. Have looked at ArchLinux, and the "make test" is commented, there for tk, but not for tcl.

I have:

$ xzgrep FAILED Downloads/blfs/tk-8.6.1-2013.09.25-09h52m12s.log.xz
==== button-5.24 ConfigureButton - computing geometry FAILED
==== button-5.24 FAILED
==== canvText-20.1 angled text bounding box FAILED
==== canvText-20.1 FAILED
==== entry-3.6 EntryWidgetCmd procedure, "bbox" widget command FAILED
==== entry-3.6 FAILED
==== entry-3.7 EntryWidgetCmd procedure, "bbox" widget command FAILED
==== entry-3.7 FAILED
==== entry-3.8 EntryWidgetCmd procedure, "bbox" widget command FAILED
==== entry-3.8 FAILED
==== entry-3.10 EntryWidgetCmd procedure, "bbox" widget command FAILED
==== entry-3.10 FAILED
==== focus-2.6 TkFocusFilterEvent procedure, FocusIn events FAILED
==== focus-2.6 FAILED
==== focus-2.7 TkFocusFilterEvent procedure, FocusOut events FAILED
==== focus-2.7 FAILED
==== focus-2.9 TkFocusFilterEvent procedure, FocusOut events FAILED
==== focus-2.9 FAILED
==== focusTcl-1.3 tk_focusNext procedure, basic tree traversal FAILED
==== focusTcl-1.3 FAILED
==== focusTcl-1.4 tk_focusNext procedure, basic tree traversal FAILED
==== focusTcl-1.4 FAILED
==== focusTcl-1.5 tk_focusNext procedure, basic tree traversal FAILED
==== focusTcl-1.5 FAILED
==== focusTcl-1.6 tk_focusNext procedure, basic tree traversal FAILED
==== focusTcl-1.6 FAILED
==== focusTcl-1.7 tk_focusNext procedure, basic tree traversal FAILED
==== focusTcl-1.7 FAILED
==== focusTcl-1.8 tk_focusNext procedure, basic tree traversal FAILED
==== focusTcl-1.8 FAILED
==== focusTcl-1.9 tk_focusNext procedure, basic tree traversal FAILED
==== focusTcl-1.9 FAILED
==== focusTcl-1.10 tk_focusNext procedure, basic tree traversal FAILED
==== focusTcl-1.10 FAILED
==== focusTcl-1.11 tk_focusNext procedure, basic tree traversal FAILED
==== focusTcl-1.11 FAILED
==== focusTcl-1.12 tk_focusNext procedure, basic tree traversal FAILED
==== focusTcl-1.12 FAILED
==== focusTcl-2.1 tk_focusNext procedure, toplevels FAILED
==== focusTcl-2.1 FAILED
==== focusTcl-2.2 tk_focusNext procedure, toplevels FAILED
==== focusTcl-2.2 FAILED
==== focusTcl-2.3 tk_focusNext procedure, toplevels FAILED
==== focusTcl-2.3 FAILED
==== focusTcl-2.4 tk_focusNext procedure, toplevels FAILED
==== focusTcl-2.4 FAILED
==== focusTcl-2.5 tk_focusNext procedure, toplevels FAILED
==== focusTcl-2.5 FAILED
==== focusTcl-3.1 tk_focusPrev procedure, no children FAILED
==== focusTcl-3.1 FAILED
==== focusTcl-3.2 tk_focusPrev procedure, basic tree traversal FAILED
==== focusTcl-3.2 FAILED
==== focusTcl-3.3 tk_focusPrev procedure, basic tree traversal FAILED
==== focusTcl-3.3 FAILED
==== focusTcl-3.4 tk_focusPrev procedure, basic tree traversal FAILED
==== focusTcl-3.4 FAILED
==== focusTcl-3.5 tk_focusPrev procedure, basic tree traversal FAILED
==== focusTcl-3.5 FAILED
==== focusTcl-3.6 tk_focusPrev procedure, basic tree traversal FAILED
==== focusTcl-3.6 FAILED
==== focusTcl-3.7 tk_focusPrev procedure, basic tree traversal FAILED
==== focusTcl-3.7 FAILED
==== focusTcl-3.8 tk_focusPrev procedure, basic tree traversal FAILED
==== focusTcl-3.8 FAILED
==== focusTcl-3.9 tk_focusPrev procedure, basic tree traversal FAILED
==== focusTcl-3.9 FAILED

Can I update the packages with these failed tests?

comment:2 by Igor Živković, 11 years ago

How does it compare with the previous version?

comment:3 by Fernando de Oliveira, 11 years ago

Both hanged, at the end of the tests and exit with errors which are apparently the same. That is whye I asked. Tail of the errors below and diff at the bottom.

==== focusTcl-3.9 tk_focusPrev procedure, basic tree traversal FAILED
==== Contents of test case:

    setup1 .
    tk_focusPrev .a

---- Test generated error; Return code was: 1
---- Return code should have been one of: 0 2
---- errorInfo: can't invoke "destroy" command: application has been destroyed
    while executing
"destroy $w.$i"
    (procedure "setup1" line 6)
    invoked from within
"setup1 ."
    ("uplevel" body line 2)
    invoked from within
"uplevel 1 $script"
---- errorCode: NONE
---- Test cleanup failed:
can't invoke "destroy" command: application has been destroyed
---- errorInfo(cleanup): can't invoke "destroy" command: application has been destroyed
    while executing
"destroy $w.$i"
    (procedure "cleanup1" line 6)
    invoked from within
"cleanup1 ."
    ("uplevel" body line 2)
    invoked from within
"uplevel 1 $cleanup"
---- errorCode(cleanup): NONE
==== focusTcl-3.9 FAILED

Error in startup script: can't invoke "winfo" command: application has been destroyed
    while executing
"winfo children ."
    (procedure "deleteWindows" line 2)
    invoked from within
"deleteWindows"
    (file "/home/fernando/tmp/paco-build-2013.09.25-09h52m12s/tk8.6.1/tests/focusTcl.test" line 267)
    invoked from within
"::source /home/fernando/tmp/paco-build-2013.09.25-09h52m12s/tk8.6.1/tests/focusTcl.test"
    ("uplevel" body line 1)
    invoked from within
"uplevel 1 [list ::source $file]"
    (procedure "tcltest::runAllTests" line 3)
    invoked from within
"tcltest::runAllTests"
    (file "/home/fernando/tmp/paco-build-2013.09.25-09h52m12s/tk8.6.1/unix/../tests/all.tcl" line 20)
make: ** [test-classic] Erro 1

$ diff -Nau Downloads/blfs/tk-8.6.0-2013.09.24-10h06m43s-failed-tests.log Downloads/blfs/tk-8.6.1-2013.09.25-09h52m12s-failed-tests.log
--- Downloads/blfs/tk-8.6.0-2013.09.24-10h06m43s-failed-tests.log	2013-09-25 11:27:32.983010051 -0300
+++ Downloads/blfs/tk-8.6.1-2013.09.25-09h52m12s-failed-tests.log	2013-09-25 11:25:44.985004276 -0300
@@ -1,13 +1,7 @@
-==== bitmap-4.1 FreeBitmapObjProc FAILED
-==== bitmap-4.1 FAILED
-==== border-3.1 FreeBorderObjProc FAILED
-==== border-3.1 FAILED
 ==== button-5.24 ConfigureButton - computing geometry FAILED
 ==== button-5.24 FAILED
 ==== canvText-20.1 angled text bounding box FAILED
 ==== canvText-20.1 FAILED
-==== cursor-4.1 FreeCursorObjProc FAILED
-==== cursor-4.1 FAILED
 ==== entry-3.6 EntryWidgetCmd procedure, "bbox" widget command FAILED
 ==== entry-3.6 FAILED
 ==== entry-3.7 EntryWidgetCmd procedure, "bbox" widget command FAILED

comment:4 by Igor Živković, 11 years ago

I'd say it's safe to update then.

comment:5 by Fernando de Oliveira, 11 years ago

OK, thanks. I will wait until later tonight, if there are no objections from Bruce or Ken, I will do it. Perhaps not today, I need to update OJDK, as Icedtea-2.4.2 has been released, and this one takes many hours to build and run the tests (hopefully without new problems).

comment:6 by bdubbs@…, 11 years ago

We currently don't recommend the tests, so I don't see a reason not to update. I'll take a look to see if I can spot why at least some of the tests fail. We may want to report the problem upstream if we can spot something definitive.

comment:7 by Fernando de Oliveira, 11 years ago

Owner: changed from blfs-book@… to Fernando de Oliveira

I missed that sentence "Running the tests is not recommended". Since the previous version, I was wanting to update this pair and would already have done it in both versions if had noticed it before. I understand you agree that I can do it.

Last edited 11 years ago by Fernando de Oliveira (previous) (diff)

comment:8 by bdubbs@…, 11 years ago

An interesting observation. I went back and redid tcl as prep to redo tk and one test failed. I dug in and it was saying / was not owned by root. LOL. Sure enough, it wasn't. It was owned by me from a previosu LFS build.

In any case, all the tcl tests now pass. I'll look at tk next.

comment:9 by bdubbs@…, 11 years ago

OK, I ran the tests and had 41 failures. My failures are significantly different from yours, although some are the same.

For instance, you failed a lot of focusTcl tests, but I didn't fail any. I failed a lot of unixfont and scrollbar tests but you didn't fail any. We both failed the same focus tests.

I think the tests are highly dependent on the screen resolution/capabilities, fonts installed, etc. We should probably say that failures will be indicated in the tests depending on these issues and will vary for different systems.

comment:10 by Fernando de Oliveira, 11 years ago

OK, thanks. I will do it and add the comment.

comment:11 by Fernando de Oliveira, 11 years ago

Resolution: fixed
Status: newclosed

Fixed at revision 11880.

comment:12 by bdubbs@…, 10 years ago

Milestone: current

Milestone current deleted

Note: See TracTickets for help on using tickets.