xscreensaver-5.27

[Fernando de Oliveira]

​http://www.jwz.org/xscreensaver/xscreensaver-5.27.tar.gz

[Fernando de Oliveira]

I am having a hell of problems with this.

First a problem with phtread, they decided to include, don't know how, solved with LIBS=-pthread .configure ... (error log at the end, below).

Second a problem with comments written in a wrong way (wrong syntax, I think), solved with a patch from gentoo. Will attach it after sending this comment.

Now, I cannot understand, when trying to make install_prefix=$DESTINODIR install, it errors with:

/usr/bin/install -c xscreensaver-text /tmp/DEST-xscreensaver-5.27/usr/bin/xscreensaver-text
make[1]: *** No rule to make target 'screensaver-properties.desktop', needed by 'install-gnome'.  Stop.
make[1]: Leaving directory '/tmp/xscreensaver-5.27/driver'
Makefile:30: recipe for target 'install' failed
make: *** [install] Error 5

Below, as mentioned above, the log for the first problem, solved.

gcc -pedantic -Wall -Wstrict-prototypes -Wnested-externs -Wmissing-prototypes 
-Wno-overlength-strings -Wdeclaration-after-statement -std=c89 
-U__STRICT_ANSI__ -L/usr/lib -o interference interference.o	screenhack.o 
fps.o ../utils/resources.o ../utils/visual.o ../utils/usleep.o 
../utils/yarandom.o  ../utils/hsv.o ../utils/colors.o ../utils/xshm.o 
../utils/xdbe.o ../utils/aligned_malloc.o ../utils/thread_util.o               
-lSM -lICE -lXt -lX11 -lXmu -lXext  -lm
../utils/thread_util.o: In function `_unlock_and_destroy':
/tmp/xscreensaver-5.27/utils/thread_util.c:703: undefined reference to 
`pthread_join'
../utils/thread_util.o: In function `_add_next_thread':
/tmp/xscreensaver-5.27/utils/thread_util.c:562: undefined reference to 
`pthread_create'
collect2: error: ld returned 1 exit status
Makefile:664: recipe for target 'interference' failed
make[1]: *** [interference] Error 1
make[1]: Leaving directory '/tmp/xscreensaver-5.27/hacks'
Makefile:26: recipe for target 'default' failed
make: *** [default] Error 5

[Fernando de Oliveira]

patcch to fix comments syntax

[Fernando de Oliveira]

First a problem with phtread, they decided to include, don't know how, solved with LIBS=-pthread .configure ... (error log at the end, below).

LIBS=-lpthread ./configure ...

[bdubbs@…]

I don't know why you need the patch. gcc certainly understands in .c code.

The install fails because it want to install suid root. You have to be root to run install, even for DESTDIR installs.

[Fernando de Oliveira]

Thank you very much, Bruce. I am trying to understand where it is trying to set uid, so I can change at least for the DESTDIR (don't like to use as root until I know where it is going).

Meanwhile, just sending the failure without the patch. I tis really necessary. I don't remember the few I read in C, but rceall comments with double bar, as you said.

gcc -pedantic -Wall -Wstrict-prototypes -Wnested-externs -Wmissing-prototypes \
-Wno-overlength-strings -Wdeclaration-after-statement -std=c89 \
-U__STRICT_ANSI__ -c -I. -I. -I./../utils -I..  -pthread \
-I/usr/include/libglade-2.0 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include \
-I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo \
-I/usr/include/pixman-1 -I/usr/include/pango-1.0 -I/usr/include/freetype2 \
-I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/freetype2 \
-I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/libxml2 \
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/glib-2.0 \
-I/usr/lib/glib-2.0/include  -pthread -I/usr/include/gdk-pixbuf-2.0 \
-I/usr/include/libpng16 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include  \
-DSTANDALONE -DHAVE_CONFIG_H  -g -O2   delaunay.c
delaunay.c: In function ‘circumcircle’:
delaunay.c:90:3: error: expected expression before ‘/’ token
   // Original
   ^
delaunay.c:92:3: error: expected expression before ‘/’ token
   // Proposed by Chuck Morris
   ^
delaunay.c:47:16: warning: variable ‘drsqr’ set but not used [-Wunused-but-set-variable]
   double dx,dy,drsqr;
                ^
delaunay.c:94:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
Makefile:531: recipe for target 'delaunay.o' failed
make[1]: *** [delaunay.o] Error 1
make[1]: Leaving directory \
'/home/fernando/tmp/paco-build-2014.05.29-20h13m42s/xscreensaver-5.27/hacks'
Makefile:26: recipe for target 'default' failed
make: *** [default] Error 5

I should have included a question mark (syntax error?).

[Fernando de Oliveira]

Tried:

sudo make install_prefix=/home/fernando/tmp/paco-build-2014.05.29-20h31m59s/DEST-xscreensaver-5.27 install

and got exactly the same error

Finally, ran the entire build as root and it installed some parts untill the same error.

[Fernando de Oliveira]

Bruce, thank you very much for your help!

Fixed at r13190.