gvfs-1.22.3

[Fernando de Oliveira]

​http://ftp.acc.umu.se/pub/gnome/sources/gvfs/1.22/gvfs-1.22.3.tar.xz

​http://ftp.acc.umu.se/pub/gnome/sources/gvfs/1.22/gvfs-1.22.3.news

Major changes in 1.22.3
=======================
* Fix metadata deamon crashes
* Several improvements to unmounting reliability
* Several smaller bugfixes
* Translation updates

[Fernando de Oliveira]

Tests are very poor. If someone could solve this, I would much appreciate. It might be some problem in my system. I've got the logs, if necessary.

----------------------------------------------------------------------
Ran 31 tests in 16.919s

FAILED (failures=2, errors=4, skipped=9)

15 of the 31 tests means eoughly 1/2.

"Fixed" at r15318.

[bdubbs@…]

Reopening to address tests.

[bdubbs@…]

When I run 'make -k check' I get (slightly edited):

Making check in common
Making check in metadata
Making check in client
Making check in daemon
Making check in trashlib
Making check in monitor
Making check in proxy
Making check in udisks2
Making check in po
make[1]: Entering directory '/tmp/gvfs/gvfs-1.22.3/po'
INTLTOOL_EXTRACT="/usr/bin/intltool-extract" XGETTEXT="/usr/bin/xgettext" \
  srcdir=.  /usr/bin/intltool-update --gettext-package gvfs --pot
rm -f missing notexist
srcdir=. /usr/bin/intltool-update -m
if [ -r missing -o -r notexist ]; then exit 1; fi
make[1]: Leaving directory '/tmp/gvfs/gvfs-1.22.3/po'
Making check in programs
Making check in test
make[1]: Entering directory '/tmp/gvfs/gvfs-1.22.3/test'
Makefile:1475: warning: overriding recipe for target 'check'
Makefile:1295: warning: ignoring old recipe for target 'check'
./run-in-tree.sh ./gvfs-test 
Traceback (most recent call last):
  File "./gvfs-test", line 38, in <module>
    from gi.repository import GLib, Gio
ImportError: No module named 'gi'
Makefile:1475: recipe for target 'check' failed
make[1]: *** [check] Error 1
make[1]: Leaving directory '/tmp/gvfs/gvfs-1.22.3/test'
Making check in man
Makefile:515: recipe for target 'check-recursive' failed
make: *** [check-recursive] Error 1
make: Target 'check' not remade because of errors.

The gvfs-test script is python3 and is failing with the line:

from gi.repository import GLib, Gio

but no other issues.

My version of gobject-introspecion is slightly out of date (1.40.0 instead of 1.42.0), but I do have /usr/lib/libgirepository-1.0.so.1.0.0 and it's associated symlinks.

My pygobject-3 is also slightly out of date (3.13.2 instead of 3.14.0), however the error says no module named gi which really wouldn't be completely missing by being only one version out of date. What am I missing here?

[Armin K]

You need to build the PyGObject module for Python 3 too. By default, it's built for Python 2 (well, for whatever /usr/bin/python points to, which is python2 in BLFS) unless specified otherwise.

[bdubbs@…]

OK, I got the python issue solved. My tests show:

FAILED (failures=3, errors=4, skipped=9), but the reasons are due to the test suite not skipping things properly if test prerequsites are not installed. The fails wer due to the system not handling ​smb:// and trash://. I do not have samba installed so that should explain the smb failures. I've never heard of a trash:// protocol.

The errors all are associated with ​ftp://. I don't have a ftp server installed, but don't know if that's the problem or not. All of the messages associated with this say: FileNotFoundError: [Errno 2] No such file or directory: 'twistd'

I tested this in /tmp/gvfs/gvfs-1.22.3/test and created a subdirectory twistd. Running ./gvfs-test then gives FAILED (failures=1, errors=21, skipped=9). The ​ftp:// errors are gone.

All the errors seem to be in the smbd portion of the tests.

I did get several messages: GLib.Error: g-io-error-quark: Operation not supported but I don't really know what that means.

We do list samba as an optional dependency. Perhaps that will enable the tests to complete.

[Fernando de Oliveira]

Replying to bdubbs@…:

You have

FAILED (failures=3, errors=4, skipped=9)

After,

FAILED (failures=1, errors=21, skipped=9).

Where did you create the subdirectory 'twistd'? I have tried many locations and got no difference.

I have samba installed and running, but the test failures with it are similar to yours.

[bdubbs@…]

I built in /tmp/gvfs/gvfs-1.22.3/. I then did:

cd test
mkdir twistd
./gvfs-test

[Fernando de Oliveira]

Thanks.

I had done that. Now I also tried building at /tmp. Always the same results.

Always the ftp and smb failures along with th twistd not found.

My latest results are the summary of what I always get:

$ ls -d ../test/twistd
../test/twistd
$ env LC_ALL=C ./gvfs-test 2>&1 | grep -E 'twistd|FAILED'
FileNotFoundError: [Errno 2] No such file or directory: 'twistd'
FileNotFoundError: [Errno 2] No such file or directory: 'twistd'
FileNotFoundError: [Errno 2] No such file or directory: 'twistd'
FileNotFoundError: [Errno 2] No such file or directory: 'twistd'
FAILED (failures=2, errors=4, skipped=9)
$ rm -rf twistd/
$ env LC_ALL=C ls -d ../test/twistd
ls: cannot access ../test/twistd: No such file or directory
$ env LC_ALL=C ./gvfs-test 2>&1 | grep -E 'twistd|FAILED'
FileNotFoundError: [Errno 2] No such file or directory: 'twistd'
FileNotFoundError: [Errno 2] No such file or directory: 'twistd'
FileNotFoundError: [Errno 2] No such file or directory: 'twistd'
FileNotFoundError: [Errno 2] No such file or directory: 'twistd'
FAILED (failures=2, errors=4, skipped=9)

[Fernando de Oliveira]

Bruce, you wrote in the fontforge ticket:

comment 9 ​http://wiki.linuxfromscratch.org/blfs/ticket/6024#comment:9

Try this:

    mkdir  test/twistd
    ./configure --prefix=/usr     \
                --sysconfdir=/etc \
                --disable-gphoto2 &&
    make                          &&

    echo "Start make check"
    make -k check
    echo "Deferred install"

    cd test
    ./gvfs-test

Or try it without the make check

I still get the same results as before.

[Armin K]

twistd is a program, part of the Twisted framework written in Python.

[bdubbs@…]

Upon further examination, the gvfs checks appear to need some (most?) of the optional dependencies including gphoto, samba, and apache. Some tests want umockdev (​https://launchpad.net/umockdev) which we don't have documented), and the package twisted.

I did figure out how to disable tests. The file gvfs-test needs to be modified (at least on my system) in three places to skip smbd, trash:// (don't know what that is), and Ftp. I added the line:

@unittest.skipIf(True, "Test3")

immediately before the offending class statement.

Even with that, I get "Ran 31 tests in 11.731s OK (skipped=19)"

My current thought is to just say that many tests will fail if associated optional dependencies are not installed. After all, it's the upstream devs that need to have a full test environment. We are really just doing confidence tests.

Thoughts?

[bdubbs@…]

I made some minor text changes about the failing tests in revision 15398. Closing.