lua-5.3.0

[bdubbs@…]

​http://www.lua.org/manual/5.3/readme.html#changes

[Armin K]

5.1 -> 5.2 upgrade broke many packages. Check if it's the case with this version before updating. VLC is the best test case I know that's in the book.

[Fernando de Oliveira]

Igor, I had failed to rediff the patch, but first tried what you did. And it works, but did not, so I started complicating. Obviously, I made some mistake.

have installed and all but one package in the book can be built, some with fixes. To be clear, I only installed up to now one dependent package, vim (graphical), because it stoped working. Apparently the before installed VLC and Totem/grilo-plugins, din't break, but I tested too fast.

tested: vim apache gtk-engines vlc grilo-plugins graphviz gegl ptlib wireshark nmap

keybinder2 already broken with previous version: (currently broken, because older lua version is required)

Unless listed below, the package doesn't need a fix to build.

Fixes:

vim-7.4 (broken, I had to re-install)

sed -i 's/luaL_optlong/(long)luaL_optinteger/' src/if_lua.c

httpd-2.4.10

sed -i 's/ldump_writer, &b/&, NULL/' ./modules/lua/mod_lua.c

vlc-2.1.5

fix must be between configure and make:

sed -i 's/luaL_optint/(int)luaL_optinteger/' \
       modules/lua/libs/{net,osd,volume}.c &&
sed -i 's/luaL_checkint(/(int)luaL_checkinteger(/' \
       modules/lua/libs/{demux,configuration,net,osd,playlist,stream,variables,volume}.c

wireshark-1.12.3:

sed -e 's/LUA_NUMBER_DOUBLE/LUA_REAL_DOUBLE/' \
    -e 's/LUA_NUMBER_INT/LUA_INTEGER/' \
    -e 's/LUA_NUMBER_LONG/LUA_INT_LONG/' \
    -e 's/LUA_NUMBER_LONGLONG/LUA_INT_LONGLONG/' \
    -e 's/LUA_NUMBER_FLOAT/LUA_REAL_FLOAT/' \
    -i epan/wslua/lua_bitop.c &&
sed -e 's/\(luaL_optint\)eger/\1/' \
    -e 's/luaL_optint/&eger/' \
    -e 's/ \(luaL_optinteger(\)/ (int)\1/' \
    -e 's/(guint)\(luaL_optinteger(\)/(lua_Unsigned)\1/' \
    -e 's/ \(luaL_opt\)long(/ (long)\1integer(/' \
    -e 's/luaL_checkint/&eger/' \
    -e 's/ \(luaL_checkinteger(\)/ (int)\1/' \
    -i epan/wslua/*.{c,h}

nmap-6.47 I am having trouble to complete the fixes. Got about five fixes, but progress stopped.

I am not sure if the fixes will fail the installed packages, but vim, view, gvim, all work fine.

Perhaps this will be useful for you.

Tomorrow, I will try again nmap. Problem is that it uses at least two functions which were removed from lua-5.3.0, and i am not understanding enough the two versions, so I could replace the code in nmap.

[Fernando de Oliveira]

BTW, I think lua is not listed in vim (BLFS) dependencies.

My fixes are not very elegant, sorry.

[Igor Živković]

This is impressive research work, Fernando! I'll leave this ticket to you if you don't mind.

[Fernando de Oliveira]

Thanks, Igor.

However, I don't think I will accept the ticket.

I cannot make nmap work with this version of lua. However, it can be built with the include lua of the tarball, using the configure switch.

--with-liblua=included

Not really sure if my fixes will break anything at runtime, that is the reason I would rather not doing the ticket. Still not in condition of taking responsibilities.

I only tested installed vim and relatives with lua-5.3.0.

Will now install the other packages, and report back later.

[Fernando de Oliveira]

I forgot to write that lua-5.2.3 was removed from the system, before the tests started, and the visble effect was to break vim.

Now, re-installed (with the fixes above, for those necessitating them):

gegl-0.2.0
graphviz-2.38.0
grilo-plugins-0.2.13
gtk-engines-2.20.2
httpd-2.4.10
nmap-6.47 with included liblua
ptlib-2.10.10
vim-7.4
vlc-2.1.5
wireshark-1.12.3

All seem to be working fine.

[Fernando de Oliveira]

Still can't build nmap with system lua.

[Fernando de Oliveira]

I have made many progresses today.

Will try to close this ticket, because it would seem good having this version for 7.7, unless there are objections.

Will change nmap to use included lua.

Please, Igor, Armin, Pierre, Ken, Bruce, any dev, I would appreciate if somebody could test, fix, rewrite in a more elegant or shorter way the seds, any input will be appreciated, anytime, either before or after the commit, which most probably will happen tomorrow.

I will change to 7.7 (milestone) and normal priority.

[bdubbs@…]

Specifically which seds?

[Fernando de Oliveira]

They are in comment:4

For wireshark-1.12.3 worries me more:

sed -e 's/\(luaL_optint\)eger/\1/' \
    -e 's/luaL_optint/&eger/' \
    -e 's/ \(luaL_optinteger(\)/ (int)\1/' \
    -e 's/(guint)\(luaL_optinteger(\)/(lua_Unsigned)\1/' \
    -e 's/ \(luaL_opt\)long(/ (long)\1integer(/' \
    -e 's/luaL_checkint/&eger/' \
    -e 's/ \(luaL_checkinteger(\)/ (int)\1/' \
    -i epan/wslua/*.{c,h}

I will send a post to dev informing the progress with nmap, so that eventually with some help, we could fix it.

[bdubbs@…]

Nothing jumps out to me for simplification. Perhaps this is a situation where a patch would work better.

[Fernando de Oliveira]

Thanks. Will create a patch, then. This was to be sent yesterday.

[Fernando de Oliveira]

I am not confident with this update I am doing.

As I wrote before, I don't want to take big tasks anymore.

This is the last one.

Please, reopen and modify any parts of it or undo it, as wished.

Done at r15381.