Opened 9 years ago

Closed 9 years ago

#6336 closed defect (fixed)

tcl: redundant sed commands when editing pkgs/tdbc1.0.3/tdbcConfig.sh

Reported by: Jeremy Henty Owned by: bdubbs@…
Priority: normal Milestone: 7.8
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description

Tcl: in the sed command that modifies pkgs/tdbc1.0.3/tdbcConfig.sh, only the first "-e ..." has any effect. The other three match nothing and can be removed. This because the string "pkgs" only appears in this file as part of the string "unix/pkgs".

Change History (2)

comment:1 by bdubbs@…, 9 years ago

Owner: changed from blfs-book@… to bdubbs@…
Status: new → assigned

comment:2 by bdubbs@…, 9 years ago

Resolution: → fixed
Status: assigned → closed

I had checked that. Note the sed is done *after* make. 

$ grep pkgs/tdbc1.0.3/ pkgs/tdbc1.0.3/tdbcConfig.sh 
tdbc_BUILD_STUB_LIB_PATH="/usr/src/tcl/tcl8.6.4/unix/pkgs/tdbc1.0.3/libtdbcstub1.0.3.a"
TDBC_BUILD_STUB_LIB_PATH="/usr/src/tcl/tcl8.6.4/unix/pkgs/tdbc1.0.3/libtdbcstub1.0.3.a"
tdbc_BUILD_INCLUDE_SPEC="-I/usr/src/tcl/tcl8.6.4/pkgs/tdbc1.0.3/generic"
TDBC_BUILD_INCLUDE_SPEC="-I/usr/src/tcl/tcl8.6.4/pkgs/tdbc1.0.3/generic"
tdbc_BUILD_LIBRARY_PATH="/usr/src/tcl/tcl8.6.4/pkgs/tdbc1.0.3/library"
TDBC_BUILD_LIBRARY_PATH="/usr/src/tcl/tcl8.6.4/pkgs/tdbc1.0.3/library"

The sed expressions 

    -e "s#$SRCDIR/pkgs/tdbc1.0.3/generic#/usr/include#"    \
    -e "s#$SRCDIR/pkgs/tdbc1.0.3/library#/usr/lib/tcl8.6#" \
    -e "s#$SRCDIR/pkgs/1.0.3#/usr/include#"            \

The third expression is wrong. The 'tdbc' is missing and should be tdbc1.0.3

Fixed at revision 15739.

Note: See TracTickets for help on using tickets.