Firefox-38.0.5, SeaMonkey-2.33.1 and Thunderbird-38.0.1 won't build with FreeType-2.6

[Wayne Blaszczyk]

I get the following error:

    INPUT("StaticXULComponentsEnd/StaticXULComponentsEnd.o")

../../gfx/skia/SkFontHost_FreeType.o: In function `SkTypeface_FreeType::onGetAdvancedTypefaceMetrics(SkAdvancedTypefaceMetrics::PerGlyphInfo, unsigned int const*, unsigned int) const':
/opt/sources/mozilla-release/gfx/skia/trunk/src/ports/SkFontHost_FreeType.cpp:560: undefined reference to `FT_Get_X11_Font_Format'
collect2: error: ld returned 1 exit status
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [realbuild] Error 2
make: *** [build] Error 2

[Wayne Blaszczyk]

​https://bugzilla.mozilla.org/show_bug.cgi?id=1143411

[Fernando de Oliveira]

Thanks, Wayne.

I knew that header was needed (from the same problem with Thunderbird).

I didn't know where to include it.

[Fernando de Oliveira]

Will fix also Thunderbird (remove the workaround) and probably Seamonkey. Tomorrow morning.

Bruce, please, would you test Seamonkey?

[bdubbs@…]

OK, I'll do SM. I've started a complete new build, but it's going OK. I've got X up. I then need to do XFCE and then I can try SM. Probably I'll be able to do it Monday.

[Wayne Blaszczyk]

I've confirmed that the following fixes the issue:

sed -i '/^ftcache.h/a ftfntfmt.h' config/system-headers

[Fernando de Oliveira]

Thanks, that was great, Wayne!!!

Thanks, Bruce. The same sed (below, not above) fixes TB and SM, most certainly.

And

sed -i '/^ftglyph.h/ i ftfntfmt.h' mozilla/config/system-headers

fixes Thunderbird and, almost certainly also, Seamonkey.

Statistics change very little:

Estimated disk space required: 3.8 GB (72 MB installed) - previous 3.9 73

Estimated build time: 8.5 SBU (with -j4) - previous 8.7

Also, with in-tree-freetype did not use harfbuzz, and looked strange. Now, it has a more familiar look (RE icons).

This last observation may finally answer a question by Ken to me, ages ago (if you don't know already the answer, Ken): it looks good using freetype built with harfbuzz support, i.e., it is worth to go the circular dependency.

[Fernando de Oliveira]

Just confirmed problem and solution with Seamonkey.

Changing the title, for future searches sake.

[Fernando de Oliveira]

Fixed at r16130.

Thanks, Wayne and Bruce.