#6797 closed enhancement (fixed)
Remove (comment out?) all instances of ftp://ftp.mozilla.org
Reported by: | Fernando de Oliveira | Owned by: | |
---|---|---|---|
Priority: | normal | Milestone: | 7.8 |
Component: | BOOK | Version: | SVN |
Severity: | normal | Keywords: | |
Cc: |
Description ¶
The contents of ftp://ftp.mozilla.org has moved to http://archive.mozilla.org
This affects:
trunk/BOOK/general/genlib/nspr.xml trunk/BOOK/general/genlib/js.xml trunk/BOOK/general/genlib/js2.xml trunk/BOOK/general.ent trunk/scripts/blfs-chapter09.php
Did it yesterday for firefox.xml, when updating, where I commented out the ftp URL.
Will try to see if I can fix the currency scripts.
Change History (10)
comment:1 by , 10 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:2 by , 10 years ago
comment:3 by , 10 years ago
Owner: | changed from | to
---|---|
Status: | assigned → new |
Partially fixed at r16333.
Didn't succeed to do it to
BLFS/trunk/scripts/blfs-chapter09.php.
Giving back to the book.
comment:4 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
The links to http://ftp.mozilla.org/pub/mozilla.org/js/ are still valid. No need to change them for js-17 and js-24.
Closing, but reopen or create a new ticket if these links become invalid.
comment:5 by , 10 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Seamonkey and Thunderbird need the ftp to be removed.
comment:7 by , 10 years ago
Status: | reopened → new |
---|
Revision r16339 broke even more blfs-chapter36.php (firefox was already broken).
Have spent some time, moved all three from ftp to http, with no difference.
BLFS Package BLFS Version Latest Flag seamonkey 2.33.1 0 * firefox 39.0.3 0 * thunderbird 38.1.0 0 *
Giving back again to the book.
comment:8 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
The change from ftp to https in the urls broke the currency scripts. The format searched for a http response is different from an ftp response so the parsing needed to be updated.
Fixed scripts in revision 16340.
follow-up: 10 comment:9 by , 10 years ago
I had done some correct modifications. Didn't work because I didn't do the format changes from ftp to http:
- return find_max( $dirs, "/\d\./", "/^.* (\d\.[\.\d]+)$/" ); + return find_max( $dirs, "/^\d\./", "/^(\d\.[\.\d]+)\/.*$/" );
and
- return find_max( $dirs, "/\d\./", "/^.*(\d{2}[\.\d]+)$/" ); + return find_max( $dirs, "/^\d/", "/^(\d{2}[\.\d]+)\/.*/" );
which I still would like understand.
I believe that:
-//$current="fontforge"; +//$current="thunderbird";
works like a changelog, right?
comment:10 by , 10 years ago
Replying to fo:
- return find_max( $dirs, "/\d\./", "/^.*(\d{2}[\.\d]+)$/" ); + return find_max( $dirs, "/^\d/", "/^(\d{2}[\.\d]+)\/.*/" );which I still would like understand.
If you do print_r($dirs); you get the output that is received and needs to be parsed. The change from \d\. to ^\d/ is to filter out all lines that do not begin with a digit. It's promarily for efficiency. The change from
^.*(\d{2}[\.\d]+)$ to ^(\d{2}[\.\d]+)\/.*/
is due to the format change in the returned listing. The leading .* is not needed, but there trailing $ is wrong and needs to be \/.*$. The \, terminates the parse for version number.
I believe that:
-//$current="fontforge"; +//$current="thunderbird";works like a changelog, right?
No. When uncommented, only the current package is tested. $current is for debugging.
That sounds very reasonable to me. I will attempt to do the same changes to the systemd book at my next commit.