Change History (5)
comment:1 by , 8 years ago
comment:2 by , 8 years ago
Alright, Bruce and I discussed this in IRC the other day. This applies to adding libidn as well, and will modify that ticket soon if necessary.
I'm copying and pasting my part of the conversation here.
I definitely think that libidn2 should be added just because libidn1 is an incomplete implementation, but I can understand why we would want to leave it out. One of the main reasons why I'm concerned about libidn2 is that it doesn't provide a .pc file. We need to keep an eye on upstream to see if they have support for it coming anytime soon. No doubt that wget2 will need it, and changing to that new version cold-turkey will cause problems.
With regarding to datefudge and cmocka, those are used in the DANE Module installed when Unbound is available at build time (runtime).
comment:3 by , 8 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Added libidn2 as an optional external dependency of GnuTLS. Clarified when cmoka and datefudge are used.
Fixed at revision 18537.
Looking at my log, it does say 'LIBIDN2 was not found', but it also says hecking for LIBIDN... yes.
We may want to add https://www.gnu.org/software/libidn/libidn2/manual/libidn2.html as and external reference but libidn id definitely used if found.
Also, I could lfind no reference in the build system to some of our other referenced external libraries: cmocka and datefudge.
I'll give this a day or two for responses but without more info intend to make the above updates.