webkitgtk-2.16.1 appears to require libnotify

[ken@…]

libnotify is shown as optional for webkitgtk, but appears to be required.

Doing a test build with minimal deps, cmake failed:

-- Looking for IceConnectionNumber in ICE - found
-- Found X11: /usr/lib/libX11.so
-- Could NOT find LibNotify (missing:  LIBNOTIFY_INCLUDE_DIRS LIBNOTIFY_LIBRARIES) 
CMake Error at Source/cmake/OptionsGTK.cmake:415 (message):
  libnotify is needed for USE_LIBNOTIFY.
Call Stack (most recent call first):
  Source/cmake/WebKitCommon.cmake:42 (include)
  CMakeLists.txt:137 (include)


-- Configuring incomplete, errors occurred!

[Douglas R. Reno]

Ken,

I can do this if you want, but if you're already there, feel free.

[Armin K]

Seems it's not strictly required: -DUSE_LIBNOTIFY=OFF might disable it.

[ken@…]

Thanks, it looks as if that works (running make now, cmake was happy). That will make it recommended. I'll report back. Douglas, if you haven't prepared it, you can pass it back to me if you wish.

[ken@…]

Yeah, it builds - I had not realised Douglas is now working on 1.16.2.

[Douglas R. Reno]

Fixed at r18714

Ken, I added an option for disabling libnotify for you.

[bdubbs@…]

Milestone renamed

[bdubbs@…]

Milestone renamed