Opened 18 years ago

Closed 18 years ago

#1793 closed task (fixed)

Vim 7.0

Reported by: alexander@… Owned by: Jeremy Huntwork
Priority: normal Milestone: 6.2
Component: Book Version: SVN
Severity: normal Keywords:
Cc:

Description

Version increment.

Attachments (4)

vim-7.0.patch (17.5 KB ) - added by zkom.xl@… 18 years ago.
vim-7.0-nogui.patch (9.8 KB ) - added by zkom.xl@… 18 years ago.
vim-7.0-mandir-1.patch (3.8 KB ) - added by alexander@… 18 years ago.
Fixes location of translated manual pages
vim-7.0-mandir-2.patch (4.1 KB ) - added by zkom.xl@… 18 years ago.

Download all attachments as: .zip

Change History (33)

comment:1 by zkom.xl@…, 18 years ago

We might want to push the new version into the book,before the freeze. There are so many new features (builtin spell checking,tab support,internal grep,better utf-8 support just to name a few),plus many bug fixes,that really worth the update. I am following the development of the new Vim,even before the alphas,and so far I didn't found any serious problems.

comment:2 by Jeremy Huntwork, 18 years ago

Milestone: Future6.2
Owner: changed from lfs-book@… to Jeremy Huntwork
Status: newassigned
Summary: Vim 7.0 is outVim 7.0

comment:3 by alexander@…, 18 years ago

Vim-7.0 (unlike 6.x) installs translated manual pages. But it puts them in directories like /usr/share/man/ru.KOI8-R and /usr/share/man/ru.UTF-8 that are not searched by Man_DB at all. What needs to be done is to put non-UTF-8 manual pages into directories like /usr/share/man/ru, and remove UTF-8 manual pages completely because Man-DB will transcode the non-UTF-8 manual pages instead.

It is still required to remove non-ISO-8859-1 tutorials.

comment:4 by Matthew Burgess, 18 years ago

There are 12 patches available at ftp://ftp.vim.org/pub/vim/patches/7.0/README. 7.0.005 doesn't apply as it's a win32 fix, but the rest do. Could someone that knows Vim better than myself comment on how critical any of the other 11 patches are please?

comment:5 by tushar@…, 18 years ago

Since the LFS policy is to use official patches (released by maintainers) when available, the patches should be used irrespective of how critical they are.

comment:6 by zkom.xl@…, 18 years ago

We can safely ignore the 7.0.005,7.0.006,7.0.007. Please review the attached patch.

comment:7 by zkom.xl@…, 18 years ago

Ops... Sorry,a small mistake,reattached. This is one big patch,update vim to 7.0.12.

comment:9 by zkom.xl@…, 18 years ago

New patch attached. It contains all the patches from 001-015 except 005. Updates vim to 7.0.15.

Description of the three new patches. 7.0.013 Insert mode completion: CTRL-L jumped back to original text 7.0.014 Motif: doesn't compile with Motif 1.2 and earlier 7.0.015 Athena: type casts for lvalues

by zkom.xl@…, 18 years ago

Attachment: vim-7.0.patch added

by zkom.xl@…, 18 years ago

Attachment: vim-7.0-nogui.patch added

comment:10 by zkom.xl@…, 18 years ago

Two new patches. 7.0.016 recognize encodings "mac-roman", "dec-mcs" and "hp-roman8" 7.0.017 (after 7.0.014) Motif: doesn't link with Motif 1.2 and earlier.

As an addition a new patch attached,wchich includes all the patches so far,but without all the gui stuff and not relative to linux platform.

Also I would like to add that there is no dependency to myspell. Plus I put an online version of the :h version7 for those who whould like to see what's new in Vim7 or to check any differences with previous versions (incompatibilities and such). http://a.hatzim.googlepages.com/version7.html

comment:11 by Jeremy Huntwork, 18 years ago

Alexander,

In my test install of vim-7.0, using DESTDIR, vim installs all man pages to /usr/man, not /usr/share/man as you said above. Here is what I have after the install:

$ ls -l /tmp/vim-test/usr/man
total 96
drwxr-xr-x 3 jhuntwork users 4096 May 25 15:46 fr
drwxr-xr-x 3 jhuntwork users 4096 May 25 15:46 fr.ISO8859-1
drwxr-xr-x 3 jhuntwork users 4096 May 25 15:46 fr.UTF-8
drwxr-xr-x 3 jhuntwork users 4096 May 25 15:46 it
drwxr-xr-x 3 jhuntwork users 4096 May 25 15:46 it.ISO8859-1
drwxr-xr-x 3 jhuntwork users 4096 May 25 15:46 it.UTF-8
drwxr-xr-x 2 jhuntwork users 4096 May 25 15:46 man1
drwxr-xr-x 3 jhuntwork users 4096 May 25 15:46 pl
drwxr-xr-x 3 jhuntwork users 4096 May 25 15:46 pl.ISO8859-2
drwxr-xr-x 3 jhuntwork users 4096 May 25 15:46 pl.UTF-8
drwxr-xr-x 3 jhuntwork users 4096 May 25 15:46 ru.KOI8-R
drwxr-xr-x 3 jhuntwork users 4096 May 25 15:46 ru.UTF-8

The directories fr and fr.ISO8859-1 are identical, as are it and it.ISO8859-1, and fr and fr.ISO8859-1. Does just removing the UTF-8 directories solve the problem?

comment:12 by alexander@…, 18 years ago

If what you say is true, then it is sufficient to run this after installation:

# There is nothing in the "ru" directory!
mv /usr/share/man/ru{.KOI8-R,}/man1/*
rm -rf /usr/share/man/*.*

I.e., remove all directories with a dot in their name. As a proof that this is sufficient and done correctly, I want the following information:

1) output of ls /usr/share/man after the whole LFS 2) screenshots of the following commands after building xterm:

LC_ALL=ru_RU.KOI8-R xterm -lc -e "man vim"
LC_ALL=ru_RU.UTF-8 xterm -lc -e "man vim"
LC_ALL=fr_FR@euro xterm -lc -e "man vim"
LC_ALL=fr_FR.UTF-8 xterm -lc -e "man vim"
LC_ALL=pl_PL.UTF-8 xterm -lc -e "man vim"
LC_ALL=pl_PL xterm -lc -e "man vim"

comment:13 by Jeremy Huntwork, 18 years ago

Well, I think I may have perhaps found the source of some of the confusion here. (At the least my own confusion.)

Here is vim's log from the jhalfs build I ran today:

http://linuxfromscratch.org/~jhuntwork/vim.log

Notice that vim only installs its man pages to /usr/man. However, a quick search shows that vim man pages are now also in /usr/share/man. Moreover, they are the same files - identical. Same inode number. No, they aren't hard-linked.

# ls -l /usr/
total 21
drwxr-xr-x  2 root root 9968 2006-05-26 14:53 bin
lrwxrwxrwx  1 root root    9 2006-05-26 09:14 doc -> share/doc
drwxr-xr-x 31 root root 4672 2006-05-26 14:48 include
lrwxrwxrwx  1 root root   10 2006-05-26 09:14 info -> share/info
drwxr-xr-x 16 root root 5712 2006-05-26 14:53 lib
drwxr-xr-x  8 root root  264 2006-05-26 09:14 local
lrwxrwxrwx  1 root root    9 2006-05-26 09:14 man -> share/man
drwxr-xr-x  2 root root 1224 2006-05-26 14:53 sbin
drwxr-xr-x 27 root root  664 2006-05-26 14:53 share
drwxr-xr-x  2 root root   48 2006-05-26 09:14 src

I, personally, never paid much attention to the fact that /usr/man is created as a symlink to /usr/share/man.

Here is the other output you requested:

# ls -l /usr/share/man
total 142
drwxr-xr-x 5 root root   120 2006-05-26 14:43 cs
drwxr-xr-x 5 root root   120 2006-05-26 14:39 de
drwxr-xr-x 5 root root   120 2006-05-26 14:39 es
drwxr-xr-x 3 root root    72 2006-05-26 14:43 fi
drwxr-xr-x 6 root root   144 2006-05-26 14:43 fr
drwxr-xr-x 3 root root    72 2006-05-26 14:53 fr.ISO8859-1
drwxr-xr-x 3 root root    72 2006-05-26 14:53 fr.UTF-8
drwxr-xr-x 5 root root   120 2006-05-26 14:43 hu
drwxr-xr-x 4 root root    96 2006-05-26 14:43 id
drwxr-xr-x 6 root root   144 2006-05-26 14:43 it
drwxr-xr-x 3 root root    72 2006-05-26 14:53 it.ISO8859-1
drwxr-xr-x 3 root root    72 2006-05-26 14:53 it.UTF-8
drwxr-xr-x 5 root root   120 2006-05-26 14:39 ja
drwxr-xr-x 2 root root  3176 2006-05-26 09:14 man0p
drwxr-xr-x 2 root root 14112 2006-05-26 14:53 man1
drwxr-xr-x 2 root root  4536 2006-05-26 09:14 man1p
drwxr-xr-x 2 root root  9632 2006-05-26 09:14 man2
drwxr-xr-x 2 root root 69968 2006-05-26 14:43 man3
drwxr-xr-x 2 root root 36448 2006-05-26 09:14 man3p
drwxr-xr-x 2 root root   944 2006-05-26 14:21 man4
drwxr-xr-x 2 root root  1832 2006-05-26 14:49 man5
drwxr-xr-x 2 root root    72 2006-05-26 09:14 man6
drwxr-xr-x 2 root root  2800 2006-05-26 14:48 man7
drwxr-xr-x 2 root root  4272 2006-05-26 14:49 man8
drwxr-xr-x 2 root root    80 2006-05-26 09:14 man9
drwxr-xr-x 5 root root   120 2006-05-26 14:43 pl
drwxr-xr-x 3 root root    72 2006-05-26 14:53 pl.ISO8859-2
drwxr-xr-x 3 root root    72 2006-05-26 14:53 pl.UTF-8
drwxr-xr-x 5 root root   120 2006-05-26 14:43 pt_BR
drwxr-xr-x 6 root root   144 2006-05-26 14:43 ru
drwxr-xr-x 3 root root    72 2006-05-26 14:53 ru.KOI8-R
drwxr-xr-x 3 root root    72 2006-05-26 14:53 ru.UTF-8
drwxr-xr-x 5 root root   120 2006-05-26 14:43 tr

Screenshots will have to wait till later.

comment:14 by alexander@…, 18 years ago

You misunderstood my request a bit. The output you provided is for vim as-is. I want fixed instructions and fixed output. There should be no directories with a dot in /usr/share/man.

Also, I am slightly against putting Vim-7.0 into LFS-6.2, for the following reason: a-a-p (required to get non-English spellfiles built) is not in BLFS.

comment:15 by DJ Lucas, 18 years ago

Also, I am slightly against putting Vim-7.0 into LFS-6.2, for the following reason: a-a-p (required to get non-English spellfiles built) is not in BLFS.


Note: I haven't tried this:

According to

http://ftp.sh.cvut.cz/MIRRORS/vim/unstable/runtime/spell/

a-a-p is not _required_. See the instructions at the bottom of the ftp directory. In fact, if this is the process you are refering to, it looks, from my POV to be more difficult to use aap. As far as aap goes, it's a python script, installation is not required, but is self explanatory if you choose to install it (./aap install). A link to aap on the vim page in BLFS should cover it if those instructions are correct proceedure you are needing.

comment:16 by alexander@…, 18 years ago

Thanks for the link. Given that pregenerated spellfiles exist (I wasn't aware of that), it would make sense to add the above link to the LFS book, and there is indeed no need to use a-a-p.

comment:17 by zkom.xl@…, 18 years ago

If vim can not find a spell file,will automatically download one,eg...

:setlocal spell spelllang=de
 Cannot find spell file for "de" in utf-8                                                                                      
 Do you want me to try downloading it?
 (Y)es, [N]o: 
 
 Downloading de.utf-8.spl...
 ***netrw*** open ftp.vim.org
 Press <cr> to continue
 In which directory do you want to write the file:
 1. /home/tms/.vim/spell
 [C]ancel, (1):
 
 Do you want me to try getting the .sug file?
 This will improve making suggestions for spelling mistakes,
 but it uses quite a bit of memory.
 [N]o, (Y)es: 

 ***netrw*** open ftp.vim.org
 Press <cr> to continue

Also,this is the correct link to do it manually. ftp://ftp.vim.org/pub/vim/runtime/spell/

by alexander@…, 18 years ago

Attachment: vim-7.0-mandir-1.patch added

Fixes location of translated manual pages

comment:18 by alexander@…, 18 years ago

Please see this patch, it fixes the manual page location issue.

by zkom.xl@…, 18 years ago

Attachment: vim-7.0-mandir-2.patch added

comment:19 by zkom.xl@…, 18 years ago

vim-7.0-mandir-2.patch attached.

Same patch with Alexander's only this time vim install it's man pages into /usr/share/man instead of /usr/man

comment:20 by Jeremy Huntwork, 18 years ago

I don't get the point of the second patch. As I showed above, /usr/man and /usr/share/man on a default LFS system are the same location.

comment:21 by zkom.xl@…, 18 years ago

Compliance with the (FHS) standards.

comment:22 by alexander@…, 18 years ago

In LFS-6.3 or 7.0, the /usr/man -> /usr/share/man symlink will be removed, because FHS doesn't allow it to exist. But now, there is indeed no difference.

comment:23 by zkom.xl@…, 18 years ago

Indeed,and and we can't claim now that we provide a (FHS) compliant system. But why we don't start right now,since Jeremy found the issue.

To be honest I had to do a DESTDIR install to discover that Jeremy was right at the first time,because I also saw in my logs that the man pages was installed in /usr/share/man. But I log everything with find/diff and find doesn't follow the symlinks by default.

It's a only a comment out and harmless and since we can do it,why not? It's a good example,just this.

comment:24 by Jeremy Huntwork, 18 years ago

I'll update the patch I committed to the patches repository. As you said, it doesn't hurt the current setup and if in the future this patch is still required but our directory layout changes, we'll be covered.

BTW, Ag is that you? Just want to confirm. :)

comment:25 by zkom.xl@…, 18 years ago

Thanks Jeremy. I think now we did our job. Bram is on vacations right now and there will be no new commit untill he return back.

I will suggest to leave the ticket open untill the release in case any new patch will get out.

Ag.

Ps.Now it's time for Randy (BLFS). :) Oh and thanks a lot for the cooperation.

comment:26 by Jeremy Huntwork, 18 years ago

Resolution: fixed
Status: assignedclosed

Yes, I believe all the known issues have been cared for here. As such, I think it's proper to close the ticket, since it's also a measure of our readiness for branching. If another issue arises, especially in connection with what was already discussed here, it's allowable to reopen the ticket. Thanks, everyone, for your help and input.

Closing as fixed with r7631.

comment:27 by jim@…, 18 years ago

Why use a patch, when you can do make MANDIR=/usr/share/man install to fix the same issue. Just curious.

comment:28 by Ag. Hatzimanikas, 18 years ago

Resolution: fixed
Status: closedreopened

I reopen this ticket,since there are already 20 or so new patches than the one we currently use in the book,so we have to replace the current patch with the vim-7.0-fixes-7.patch (that submitted by Jim),before the release. http://www.linuxfromscratch.org/patches/downloads/vim/vim-7.0-fixes-7.patch

comment:29 by bdubbs@…, 18 years ago

Resolution: fixed
Status: reopenedclosed

Fixed at revision 7692.

Note: See TracTickets for help on using tickets.