Opened 15 years ago
Closed 15 years ago
#2329 closed task (fixed)
Zlib FPIC patch
| Reported by: | willimm | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.5 |
| Component: | Book | Version: | SVN |
| Severity: | normal | Keywords: | |
| Cc: |
Description
CLFS is using a patch for Zlib that allows Zlib to both build shared and non-shared libraies together. Pretty nifty.
It is attached with this ticket.
Attachments (1)
Change History (8)
by , 15 years ago
| Attachment: | zlib-1.2.3-fPIC-1.patch added |
|---|
comment:1 by , 15 years ago
| Milestone: | 7.0 → 6.5 |
|---|
comment:2 by , 15 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:4 by , 15 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
The zlib-1.2.3-fPIC-1.patch patch builds the static library with -fPIC. Some of the advantages of static linking are lost with this. Fedora uses this patch:
http://cvs.fedoraproject.org/viewvc/devel/zlib/zlib-1.2.3-autotools.patch
Fedora's patch builds each object twice, once with -fPIC, and again without.
The downside is that Fedora's patch becomes 1.3MB after autoreconf is run.
I suggest we use neither patch and go back to how it was before. The current patch compiles libz.a incorrectly.
comment:5 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Reverted to building static and dynamic libraries separately.
Fixed at r8932.
comment:6 by , 15 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Re-opening this ticket. The patch is still referenced in Chapter 3 - Patches.
Bruce, I'll let you do that part or at least comment that is can be removed in case there's something I missed. I believe it's just a left-over from revision 8932's commit where you reversed the zlib installation back to its two passes.
comment:7 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Zlib FPIC patch. Pretty nifty.