Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#2643 closed enhancement (fixed)

Coreutils-8.5

Reported by: Matthew Burgess Owned by: Matthew Burgess
Priority: normal Milestone: 6.7
Component: Book Version: SVN
Severity: normal Keywords:
Cc:

Description

Attachments (2)

coreutils-8.5-uname-1.patch (1.6 KB ) - added by willimm 14 years ago.
Coreutils Uname Patch. Note, this is not the same one in that is currently in the book, it's a cleaner version from Fedora that basically does the same thing as the old patch.
coreutils-8.5-i18n-1.patch (117.9 KB ) - added by willimm 14 years ago.
Coreutils i18n patch, updated for 8.5.

Download all attachments as: .zip

Change History (9)

by willimm, 14 years ago

Attachment: coreutils-8.5-uname-1.patch added

Coreutils Uname Patch. Note, this is not the same one in that is currently in the book, it's a cleaner version from Fedora that basically does the same thing as the old patch.

by willimm, 14 years ago

Attachment: coreutils-8.5-i18n-1.patch added

Coreutils i18n patch, updated for 8.5.

comment:1 by willimm, 14 years ago

I've got two patches ready for this version, in case you haven't noticed. Of cource, I have a new i18n patch, but, for the Uname patch, I settled on a similar patch from Fedora that's cleaner and basically does the same thing.

Since I've got the patches ready, this should be very simple to put in the book, just the usual package stats that have to be done before this goes into the book.

comment:2 by Matthew Burgess, 14 years ago

Owner: changed from lfs-book@… to Matthew Burgess
Status: newassigned

comment:3 by willimm, 14 years ago

I was wondering why you are still using the old uname major hack patch for coreutils, and not Fedora's better and cleaner uname patch. I'd love to see the Fedora patch included in the book, and not the old major hack patch.

comment:4 by Matthew Burgess, 14 years ago

Because I'm lazy and didn't even see your patches attached to this ticket, William :-) I agree that the Fedora patch is much cleaner, so I'll add that to my working copy and to the patches repository!

comment:5 by Matthew Burgess, 14 years ago

Resolution: fixed
Status: assignedclosed

Fixed in r9272.

comment:6 by willimm, 14 years ago

One minor thing: Since the Fedora uname patch is listed as coreutils-8.5-uname-2.patch, and the old major hack patch is listed as coreutils-8.5-uname-1.patch, the book uses the major hack version instead of the proper Fedora version. So, either:

  1. The Fedora uname patch should be renamed as coreutils-8.5-uname-1.patch, or
  2. The book should be updated to use the Fedora version of the Uname patch instead of the old version.

Minor regression, but still worth pointing out.

in reply to:  6 comment:7 by willimm, 14 years ago

Replying to willimm:

One minor thing: Since the Fedora uname patch is listed as coreutils-8.5-uname-2.patch, and the old major hack patch is listed as coreutils-8.5-uname-1.patch, the book uses the major hack version instead of the proper Fedora version. So, either:

  1. The Fedora uname patch should be renamed as coreutils-8.5-uname-1.patch, or
  2. The book should be updated to use the Fedora version of the Uname patch instead of the old version.

Minor regression, but still worth pointing out.

Oops, forgot that you changed it in the general.ent. My bad.

Note: See TracTickets for help on using tickets.