Opened 13 years ago
Closed 13 years ago
#3057 closed task (fixed)
su-tools is not convenient
| Reported by: | Gilles Espinasse | Owned by: | Matthew Burgess |
|---|---|---|---|
| Priority: | normal | Milestone: | 7.2 |
| Component: | Book | Version: | SVN |
| Severity: | normal | Keywords: | |
| Cc: |
Description
particulary when you want to report chap-6 coreutils test issue as you have to explain what su-tools artifact is.
You may understand what I mean if you actually try coreutils-8.16 test suite that fail for me with
../build-aux/test-driver: line 95: 8323 Aborted "$@" > $log_file 2>&1 FAIL: test-getlogin
I would suggest fixing su-tools to be /tools/bin/su in chap-6.6. That would need to adjust chap6.24 (coreutils) and chap-6.31 (bash) test suites.
Why is still su-tools used in chap6.31 is another question as new su has been installed in chap-6.24 (coreutils)
Change History (4)
comment:1 by , 13 years ago
comment:2 by , 13 years ago
For bash test, just replacing su-tools with su would clean the book.
What I made for my system in the chap-6.6 equivalent is
SU=/$(TOOLS_DIR)/bin/su; install -m 4775 $SU-tools $SU
That way, su is available for chap-6 build. I choose install as it was simplier than chown and chmod
comment:3 by , 13 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
Note:
See TracTickets
for help on using tickets.
I'm not sure of the history behind naming 'su' as 'su-tools' in chapter 5. I'd guess that the fact that bash still uses it is an artefact of chapter re-ordering during the project's history. It should be safe to fix that up.
As far as the Coreutils test failure, I'm going to report it upstream. It's failing an assertion in the test program that thinks getlogin() should have set errno to ENOTTY or EINVAL. What it actually returns is ENOENT, which is documented here: http://linux.die.net/man/3/getlogin. I'll move further discussion of this test failure to #3048.