Opened 11 years ago

Closed 11 years ago

#3316 closed enhancement (fixed)

procps-ng-3.3.7

Reported by: Gilles Espinasse Owned by: Matthew Burgess
Priority: normal Milestone: 7.4
Component: Book Version: SVN
Severity: normal Keywords:
Cc:

Description

Announced very shortly at http://www.freelists.org/post/procps/procpsng-337-released

md5 : 57d2bad8c8fac3d09ee9f5f964e3da9c

There is a few fixes and most changes are on top and pmap. Concerning the test suite issues :

  • the pmap_initname issue has not been investigated, test work for me on opensuse-3.7.10-1.1-default
  • the slabtop issue has been fixed twice, once right, once wrong, so LFS would need now
sed -e 's|&9|9999999|' on testsuite/config/unix.exp

The kill not build test issue is fixed but only using

make check

If using 'DEJAGNU=global-conf.exp runtest' that produce a simplier output to read, the only way I find to fix the test result is the brutal and effective

rm -rf testsuite/kill.test

git diff --stat v3.3.6..v3.3.7
 COPYING.LIB                                        |    2 +-
 Documentation/CodingStyle                          |    2 +-
 Documentation/TODO                                 |    2 +-
 .../howto-uClibc-buildroot-compilation.txt         |    4 +-
 NEWS                                               |   14 +
 configure.ac                                       |    8 +
 contrib/tmp-junk.c                                 |    4 +-
 contrib/utmp.c                                     |   12 +-
 free.1                                             |    2 +-
 include/nls.h                                      |    2 +-
 include/strutils.h                                 |    2 +-
 include/xalloc.h                                   |    2 +-
 lib/strutils.c                                     |    2 +-
 pgrep.1                                            |   19 +-
 pgrep.c                                            |   58 +-
 pmap.c                                             |  823 +++++++++++++----
 proc/COPYING                                       |    2 +-
 proc/Makefile.am                                   |    2 +-
 proc/devname.c                                     |    2 +-
 proc/escape.c                                      |   34 +-
 proc/ksym.c                                        |    2 +-
 proc/readproc.c                                    |  129 ++-
 proc/slab.c                                        |   75 +-
 proc/sysinfo.c                                     |   42 +-
 proc/version.c                                     |    4 +-
 ps/display.c                                       |    1 +
 ps/parser.c                                        |   20 +-
 ps/ps.1                                            |    6 +-
 slabtop.1                                          |    2 +-
 sysctl.8                                           |    2 +-
 testsuite/Makefile.am                              |    7 +-
 testsuite/config/unix.exp                          |   24 +-
 testsuite/pmap.test/pmap.exp                       |    4 +-
 top/top.1                                          |  341 ++++++-
 top/top.c                                          | 1030 +++++++++++++-------
 top/top.h                                          |   91 ++-
 top/top_nls.c                                      |   69 +-
 top/top_nls.h                                      |   26 +-
 w.c                                                |    6 +-
 39 files changed, 2062 insertions(+), 817 deletions(-)

Change History (4)

comment:1 by Matthew Burgess, 11 years ago

Owner: changed from lfs-book@… to Matthew Burgess
Status: newassigned
Type: taskenhancement

comment:2 by Gilles Espinasse, 11 years ago

I find the right way to skip kill test. That should be for 3.3.8

diff --git a/testsuite/kill.test/kill.exp b/testsuite/kill.test/kill.exp
index 8b0d61b..bed50a8 100644
--- a/testsuite/kill.test/kill.exp
+++ b/testsuite/kill.test/kill.exp
@@ -3,6 +3,11 @@
 #
 set kill ${topdir}kill
 
+if { ![ file exists $kill ] } {
+    untested { skipping (not build)}
+    return
+}
+
 set test "kill with no arguments"
 spawn $kill
 expect_pass "$test" "Usage:\\s+\(lt-\)?kill \\\[options\\\] <pid> \\\[...\\\]\\s+Options:\\s+<pid> \\\[...\\\]\\s+send signal to every <pid> listed\\s+-<signal>, -s, --signal <signal>\\s+specify the <signal> to be sent\\s+-l, --list=\\\[<signal>\\\]\\s+list all signal names, or convert one to a name\\\s+-L, --table\\s+list all signal names in a nice table$usage_help$usage_version$usage_man"
-- 
1.7.2.5

While testing, I find that runtest -a produce an output I find better than only runtest.

comment:3 by Gilles Espinasse, 11 years ago

Another simple way to skip kill test in 3.3.7 is

runtest --ignore kill.exp

comment:4 by Matthew Burgess, 11 years ago

Resolution: fixed
Status: assignedclosed

Fixed in r10223.

Note: See TracTickets for help on using tickets.