Opened 4 years ago

Closed 4 years ago

#4699 closed task (fixed)

bison-3.7.1

Reported by: Bruce Dubbs Owned by: lfs-book
Priority: normal Milestone: 10.0
Component: Book Version: SVN
Severity: normal Keywords:
Cc:

Description

New minor version.

Change History (7)

comment:1 by ken@…, 4 years ago

FTBFS:

/usr/bin/ld: src/bison-complain.o: in function `warnings_print_categories':
/tmp/bison-3.7/src/complain.c:457: undefined reference to `ostream_printf'

(etc)

Already reported upstream by gentoo in thread which starts at https://lists.gnu.org/archive/html/bug-bison/2020-07/msg00033.html

comment:2 by Bruce Dubbs, 4 years ago

Upstream is being too clever. There is one place that uses ostream_printf and another that uses styled_ostream_set_hyperlink, These are just used to format error messages in complain.c.

I was able to get bison to build by adding the following:

static inline ptrdiff_t
ostream_printf (ostream_t stream, const char *format, ...)
{
  va_list args;
  char *temp_string;
  ptrdiff_t ret;

  va_start (args, format);
  ret = vasprintf (&temp_string, format, args);
  va_end (args);
  if (ret >= 0)
    {
      if (ret > 0)
        ostream_write_str (stream, temp_string);
      free (temp_string);
    }
  return ret;
}

to complain.c. I also needed to comment out styled_ostream_set_hyperlink in two places. I took the ostream_printf function from lib/textstyle.in.h.

I'd rather add a patch to bison rather than a new library.

comment:3 by Bruce Dubbs, 4 years ago

Seems to build OK with gettext-0.21. Patch not needed. All tests pass.

comment:4 by Pierre Labastie, 4 years ago

Summary: bison-3.7bison-3.7.1

comment:5 by Pierre Labastie, 4 years ago

Now 3.7.1.

comment:6 by Bruce Dubbs, 4 years ago

GNU Bison NEWS

  • Noteworthy changes in release 3.7.1 (2020-08-02) [stable]
  • Bug fixes
    • Crash when a token alias contains a NUL byte.
    • Portability issues with libtextstyle.
    • Portability issues of Bison itself with MSVC.
  • Changes
    • Improvements and fixes in the documentation.
    • More precise location about symbol type redefinitions.

comment:7 by Bruce Dubbs, 4 years ago

Resolution: fixed
Status: newclosed

Fixed at revision 12007.

Note: See TracTickets for help on using tickets.