Remove &&<cr> in BLFS scripts

[Pierre Labastie]

If you have instructions of the form:

instruction A &&
instruction B &&
instruction C

and A fails, B and C are not executed (which is what is intended), but the error code is 0 (because bash thinks it is equivalent to:

if instruction A; then
  if instruction B; then
    instruction C
  fi
fi

which returns an error code only if C is executed and exits with an error.

This is not desirable in our case, because it defeats the use of set -e.

[Pierre Labastie]

This should be easy enough. of course, only && at the end of lines should be removed. But it is possible the a dev intends to have:

long instruction A &&
  instruction B

to be equivalent to:

if long instruction A; then
  instruction B

How to know? Ask dev to not use the && construct? When long instruction A is of the form [ -letter something ], that may be detected, but otherwise?

[Pierre Labastie]

I think I'll remove the &amp;&amp;&#xA; except when preceded by [...] or test ...

[Pierre Labastie]

Fixed at r4100