Opened 8 years ago

Closed 7 years ago

#1709 closed defect (fixed)

quote bash variables when passing them to xsltproc

Reported by: Pierre Labastie Owned by: Pierre Labastie
Priority: normal Milestone: 2.4.1
Component: jhalfs Version: 2.4
Severity: normal Keywords:
Cc:

Description

When we have something like:

--stringparam param1 $PARAM1 \
--stringparam param2 $PARAM2

and the variable PARAM1 is empty, what is passed to the xsl program is:

  • param1 contains --stringparam
  • param2 is taken as the name of an external entity to be read by the program.

and the following stringparam's have bogus values (if they have any). At least, this should be changed to:

--stringparam param1 "$PARAM1" \
--stringparam param2 "$PARAM2"

but it'd be better to test whether those variables are empty.

Change History (2)

comment:1 by Pierre Labastie, 7 years ago

Owner: changed from alfs-log@… to Pierre Labastie
Status: newassigned

comment:2 by Pierre Labastie, 7 years ago

Resolution: fixed
Status: assignedclosed

fixed in trunk at r3970, and in 2.4 branch at r3971

Note: See TracTickets for help on using tickets.