Opened 15 months ago
Closed 6 months ago
#1735 closed enhancement (worksforme)
Set TESTSUITEFLAGS=-jN in envars
Reported by: | xry111 | Owned by: | |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | jhalfs | Version: | GIT |
Severity: | normal | Keywords: | |
Cc: |
Description
Recently I found setting TESTSUITEFLAGS=-j4 for Tar can significantly accelerate the testing. To me we should just set it for all packages (in LFS book we can add it and MAKEFLAGS into the env command of "Entering the Chroot Environment" as well), instead of do it for specific packages.
Change History (6)
comment:1 by , 15 months ago
comment:2 by , 15 months ago
Looks like only autoconf, bison, kbd, libtool (see below), and tar reference TESTSUITEFLAGS:
In addition, libtool has also a INNER_TESTSUITEFLAGS variable. The problem is that no example in libtool tells whether to pass -jX
into TESTSUITEFLAGS or INNER_TESTSUITEFLAGS.
follow-up: 4 comment:3 by , 15 months ago
Type: | defect → enhancement |
---|
Maybe it should actually be a LFS change.
comment:4 by , 15 months ago
Replying to xry111:
Maybe it should actually be a LFS change.
I'm not sure what our policy is, respective to timing: should we count everything at -j4 (in which case I think we should pass TESTSUITEFLAGS
when calling make check, or are still official timings done at -j1? In the latter case, it would be ALFS job to set TESTSUITEFLAGS=$MAKEFLAGS
.
comment:5 by , 15 months ago
For the record: HARNESS_JOBS=$(nproc) significantly accelerates OpenSSL test suite. This is suitable for all packages using Perl Test::Harness module for testing.
comment:6 by , 6 months ago
Resolution: | → worksforme |
---|---|
Status: | new → closed |
Fixed on the LFS side for a long time.
Setting MAKEFLAGS per packages used to allows overriding it in
BLACK_LIST
in optimize/opt_config. But BLACK_LIST is empty now, so the question is whether we might need to use it again... I'd be inclined to keep a per package setting, but adding TESTSUITEFLAGS to the settings.