Opened 6 months ago
Last modified 6 months ago
#1739 accepted defect
Reorder or remove deleting the lfs user
| Reported by: | xry111 | Owned by: | Pierre Labastie |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | jhalfs | Version: | GIT |
| Severity: | normal | Keywords: | |
| Cc: |
Description
Currently we are deleting the lfs user before 701-changingowner. This is bad because between these two steps there's a time point where the LFS system is owned by an unnamed UID. And it's blown up after https://wiki.linuxfromscratch.org/lfs/changeset/6e179a90255308dc64eec386fb3ae49ab16acca4.
For now I've filtered out --step lfs from 701-changingowner but it's not an ideal solution.
And DJ believes we should just not delete the lfs user.
Note:
See TracTickets
for help on using tickets.
I agree removing the lfs user is not part of the book. But creating it is! So a real testing of book instructions involves creating the lfs user. This is of course impossible if the lfs user already exists. This leads me to think we should always remove the lfs user before doing anything in jhalfs. This would solve the ordering problem, and allow testing the book instructions. But this has a drawback if for any reason there is a permanent lfs user on the host, which should never be deleted. Since we already save the lfs user directory when the lfs user already exists, we could add lfs user removal after that. But then, when recreating it, it may appear with a different uid, so that it wouldn't own the saved directory. Well, in this case, just add a chown when replacing the directories in their correct location. Will try to come up with something.