Opened 21 years ago

Closed 21 years ago

Last modified 20 years ago

#612 closed enhancement (fixed)

Support for multiple <reference>s

Reported by: neven@… Owned by: kpfleming@…
Priority: normal Milestone:
Component: nALFS - Back End (XML Handlers) Version: SVN
Severity: minor Keywords:
Cc:

Description

When fetching file from <reference> fails, we should check for another one.

Change History (11)

comment:1 by gerard@…, 21 years ago

qa_contact: alfs-discuss@linuxfromscratch.orgalfs-log@linuxfromscratch.org

comment:2 by gerard@…, 21 years ago

Owner: changed from alfs-discuss@… to alfs-log@…
Version: CVS1.1.7

comment:3 by kpfleming@…, 21 years ago

Will combine code from new-download and new-unpack into library this weekend, which will resolve this issue. Please assign to me.

comment:4 by neven@…, 21 years ago

Owner: changed from alfs-log@… to kpfleming@…
Priority: lowestnormal

comment:5 by kpfleming@…, 21 years ago

dependson: 671

comment:6 by kpfleming@…, 21 years ago

Status: newassigned

comment:7 by kpfleming@…, 21 years ago

Resolution: fixed
Status: assignedclosed

patch committed to CVS

comment:8 by neven@…, 21 years ago

Keywords: VERIFIED added
Version: 1.1.7CVS

I would add some new functions in there, it started to turn into spaghetti code a bit (continue, break, goto -- all in one).

But it's not a big deal of course -- it works, which is important. :-)

comment:9 by kpfleming@…, 21 years ago

Yeah, my first plan was to create get_urls() and pass it the name of the multi-instance element that holds the URLs. Problem with that is that <download> and <unpack> construct their URLs differently (<reference> is a complete URL, where <url> is only a prefix), so that would get_urls() would need a callback to a function to create the final URL... too much pain for little gain. Maybe just break out the code into a separate function in each handler, but not try to consolidate them.

When it comes time to add <reference> support to <patch> as I want to do, I'll revisit this topic.

comment:10 by neven@…, 21 years ago

Keywords: VERIFIED removed

comment:11 by jwrober@…, 20 years ago

Version: CVSSVN
Note: See TracTickets for help on using tickets.