Opened 21 years ago

Closed 21 years ago

Last modified 21 years ago

#734 closed defect (fixed)

Temp file rename does not work properly

Reported by: ookaze@… Owned by: alfs-log@…
Priority: lowest Milestone:
Component: nALFS - Back End (XML Handlers) Version: 1.2.0
Severity: blocker Keywords:
Cc:

Description

The rename() in get_url can not work when nALFS is launched on a different filesystem than the one where the file should be downloaded. The temp_file_name seems to be created in the current directory, which is not my "destination" directory, and they are on different filesystems. Hence, the rename fails. I've patched the get_url utility for it to add the destination path, but perhaps it is not optimal. The URL is the location of my patch. If it doesn't break some nALFS rule, it would be good to have an official patch. Thanks

Attachments (1)

nALFS-1.2.0.patch (1.8 KB ) - added by ookaze@… 21 years ago.
my overall patch for nALFS-1.2.0

Download all attachments as: .zip

Change History (5)

by ookaze@…, 21 years ago

Attachment: nALFS-1.2.0.patch added

my overall patch for nALFS-1.2.0

comment:1 by kpfleming@…, 21 years ago

bug_file_loc: ftp://localhost/pub/nALFS-1.2.0.patch
Resolution: fixed
Status: newclosed

Analysis is correct; this bug was introduced when my initial code was changed to use create_temp_file. I have corrected this bug in the CVS version, using a simpler technique than the posted patch. If you're willing, please give it a test run and ensure it works for you. Thanks!

comment:2 by ookaze@…, 21 years ago

Works perfectly for me ! Thanks :)

comment:3 by kpfleming@…, 21 years ago

Keywords: VERIFIED added

comment:4 by kpfleming@…, 21 years ago

Keywords: VERIFIED removed
Note: See TracTickets for help on using tickets.