lame-4.0 (Wait for 4.1)

[Bruce Dubbs]

New major version.

[Bruce Dubbs]

Note: this is is first update since 2017.

[Joe Locash]

This FTBFS. Upstream ticket: ​https://sourceforge.net/p/lame/bugs/523/

[Bruce Dubbs]

Evidently the person who did this update just checked that it built on windows.

I got this to compile with:

sed -i -e 's/^\(\s*hardcode_libdir_flag_spec\s*=\).*/\1/' configure &&
sed -i '/hip_decode1_headersB/a hip_finish_pinfo' include/libmp3lame.sym &&
export CFLAGS+=" -Wno-implicit-function-declaration -Wno-incompatible-pointer-types" &&
./configure --prefix=/usr --enable-mp3rtp --disable-static &&
make

But the link phase of the frontend/ fails with

'undefined reference to `id3tag_set_textinfo_utf8'

That function is in libmp3lame/.libs/id3tag.o, but adding that creates cascading undefined references.

I'm inclined to just make this wontfix and use the current version in the book that seems to have been working for the last 10 years.

[Xi Ruoyao]

4.0 still FTBFS.

[Bruce Dubbs]

Replying to Xi Ruoyao:

4.0 still FTBFS.

Upstream claims it will be fixed in 4.1.

[Joe Locash]

Replying to Bruce Dubbs:

Upstream claims it will be fixed in 4.1.

The latest svn builds fine.

[zeckma]

mpg123 should be added as a recommended dependency in 4.x for use with decoding, but can be disabled via --disable-decoder.

[zeckma]

This update is a security release, enabling security hardening by default, rejecting interleaving encodings on single channels, and fixed an integer underflow. There is another security fix that is Windows-only as it involves DLLs.

See ​https://svn.code.sf.net/p/lame/svn/trunk/lame/doc/html/history.html for more information.

[zeckma]

Here is a patch I created to fix LAME-4.0 without the need for CFLAGS and it properly fixes the code.