Opened 3 years ago

Closed 3 years ago

#4700 closed task (fixed)


Reported by: Bruce Dubbs Owned by: lfs-book
Priority: normal Milestone: 10.0
Component: Book Version: SVN
Severity: normal Keywords:


New point version.

Change History (6)

comment:1 by Pierre Labastie, 3 years ago

Sun July 19, 2020: Released Check 0.15.1
  based on hash db3ef470271e6e011f2cd1f5231a50375568bb46

* Fix warning in ptr macros with pointer to integer cast
  Issue #284

* Fix various warnings in Check's unit tests
  Issue #283

* Replace gnu_printf with printf in format __attribute__
  Issue #282

* Fix warnings from Check's macros: "warning: too many arguments for format"
  Issue #274

* Fix format specifiers that do not match the argument types
  Issue #271

comment:2 by Pierre Labastie, 3 years ago

Looks like the libpipeline testsuite completely fails to compile with this version of check. The error is:

In file included from common.h:3,
                 from argstr.c:28:
argstr.c: In function 'test_argstr_trivial_fn':
argstr.c:40:2: error: too few arguments to function '_ck_assert_failed'
   40 |  fail_unless (!strcmp (cmd->name, "/bin/simple"));
      |  ^~~~~~~~~~~
/usr/include/check.h:502:27: note: declared here
  502 | CK_DLL_EXP void CK_EXPORT _ck_assert_failed(const char *file, int line,
      |                           ^~~~~~~~~~~~~~~~~

Note that there are lots of similar errors, all involving fail_unless and _ck_assert_failed, the only thing changing being the .c file name. This complicated sed (maybe it can be simplified), allows the tests to build and pass (apply the sed in libpipeline):

sed -i '/\(fail_unless\|fail_if\) (\([^,]*([^)]*)[^,]*\|\[^,]*\));/s/);/,0);/' tests/*.c

comment:3 by Pierre Labastie, 3 years ago

FWIIW, there is a bug report for the pipeline tests issue now:

comment:4 by Bruce Dubbs, 3 years ago

I've already committed a patch:

It will be in my next commit, but I'm still waiting for glibc-2.32 which is overdue.

If upstream releases a new version, we can drop it.

comment:6 by Bruce Dubbs, 3 years ago

Resolution: fixed
Status: newclosed

Fixed at revision 12007.

Note: See TracTickets for help on using tickets.