Opened 3 years ago
Closed 3 years ago
#4700 closed task (fixed)
|Reported by:||Bruce Dubbs||Owned by:||lfs-book|
New point version.
Change History (6)
comment:1 by , 3 years ago
comment:2 by , 3 years ago
Looks like the libpipeline testsuite completely fails to compile with this version of check. The error is:
In file included from common.h:3, from argstr.c:28: argstr.c: In function 'test_argstr_trivial_fn': argstr.c:40:2: error: too few arguments to function '_ck_assert_failed' 40 | fail_unless (!strcmp (cmd->name, "/bin/simple")); | ^~~~~~~~~~~ /usr/include/check.h:502:27: note: declared here 502 | CK_DLL_EXP void CK_EXPORT _ck_assert_failed(const char *file, int line, | ^~~~~~~~~~~~~~~~~
Note that there are lots of similar errors, all involving fail_unless and _ck_assert_failed, the only thing changing being the .c file name. This complicated sed (maybe it can be simplified), allows the tests to build and pass (apply the sed in libpipeline):
sed -i '/\(fail_unless\|fail_if\) (\([^,]*([^)]*)[^,]*\|\[^,]*\));/s/);/,0);/' tests/*.c
comment:3 by , 3 years ago
FWIIW, there is a bug report for the pipeline tests issue now: https://savannah.nongnu.org/bugs/?58883.
comment:4 by , 3 years ago
I've already committed a patch:
It will be in my next commit, but I'm still waiting for glibc-2.32 which is overdue.
If upstream releases a new version, we can drop it.
comment:5 by , 3 years ago
Upstream has published a fix: https://git.savannah.gnu.org/cgit/libpipeline.git/commit/?id=1be57f95c30cbaa6f64ae11a6d952fe4633e29f2 I've taken this for a second version of the patch: http://www.linuxfromscratch.org/patches/downloads/libpipeline/libpipeline-1.5.2-check_fixes-2.patch
comment:6 by , 3 years ago
|Status:||new → closed|
Fixed at revision 12007.