librsvg-2.46.1

[Douglas R. Reno]

New point version

[Xi Ruoyao]

Version 2.46.1
- #506 - Fix empty patterns which reference a fallback pattern with
  children.

[Bruce Dubbs]

This package will not build for me with rustc 1.35.0. I get two instances of:

error[E0658]: use of unstable library feature 'maybe_uninit' in

vendor/string_cache/src/atom.rs

We may need to update rustc for this.

[ken@…]

If it builds with 1.37.0 we can do it, if not it will have to wait until thunderbird can build with a newer version.

I've got 1.37.0 on another system on the machine I'm using, need to finish quite a lot of other things before I can look at that.

[Douglas R. Reno]

Check this out (it is due to rustc < 1.36.0)... ​https://gitlab.gnome.org/GNOME/librsvg/issues/516

There's a fix in this commit:

​https://gitlab.gnome.org/GNOME/librsvg/commit/7ee553d5f99ceb741d4e1751e39fef345107b4f4

[ken@…]

Replying to renodr:

Check this out (it is due to rustc < 1.36.0)... ​https://gitlab.gnome.org/GNOME/librsvg/issues/516

There's a fix in this commit:

​https://gitlab.gnome.org/GNOME/librsvg/commit/7ee553d5f99ceb741d4e1751e39fef345107b4f4

No obvious way to get a usable diff from that commit (as distinct from the coloured or side-by-side diffs I can see in my browser). Thanks for pointing to the "needs to be at least 1.36.0" issue.

[Douglas R. Reno]

It's actually a bug in the servo crate (string-cache):

​https://github.com/servo/string-cache/issues/228

We're probably better off updating rustc. It is in fact fixed by rustc-1.36.0 however.

The bug report in librsvg refers to rustc-1.34.2

[Douglas R. Reno]

In fact, the minimum dependency for that crate is now 1.36.0. We'll need a rustc update.

[Pierre Labastie]

Replying to ken@…:

Replying to renodr:

There's a fix in this commit:

​https://gitlab.gnome.org/GNOME/librsvg/commit/7ee553d5f99ceb741d4e1751e39fef345107b4f4

No obvious way to get a usable diff from that commit (as distinct from the coloured or side-by-side diffs I can see in my browser). Thanks for pointing to the "needs to be at least 1.36.0" issue.

Not sure we need the patch here, but may be of general use for gitlab patches: Click on the "Options" button (on the top right), then "Plain Diff"

[Xi Ruoyao]

Replying to ken@…:

Replying to renodr:

Check this out (it is due to rustc < 1.36.0)... ​https://gitlab.gnome.org/GNOME/librsvg/issues/516

There's a fix in this commit:

​https://gitlab.gnome.org/GNOME/librsvg/commit/7ee553d5f99ceb741d4e1751e39fef345107b4f4

No obvious way to get a usable diff from that commit (as distinct from the coloured or side-by-side diffs I can see in my browser). Thanks for pointing to the "needs to be at least 1.36.0" issue.

In Gitlab we can simply add a ".patch" in commit URL to get the patch:

​https://gitlab.gnome.org/GNOME/librsvg/commit/7ee553d5f99ceb741d4e1751e39fef345107b4f4.patch

[Douglas R. Reno]

With rustc-1.37.0, it builds fine. The patch is useless in this case, it was applied before they released 2.46.1. The commit section of gitlab is confusing sometimes, and I missed that.

With rustc-1.35.0, I get the same problem as Bruce did. It seems to be a problem in a dependency crate, "string_cache", as it now depends on features that were added in 1.36.0. We'll have to upgrade to rustc-1.37.0 (per Ken's suggestion earlier in this ticket) at some point.

[Bruce Dubbs]

Fixed at revision 22248.