Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#8381 closed enhancement (fixed)

perl modules - remove Encode-JISX0213 and Encode-ISO2022

Reported by: ken@… Owned by: ken@…
Priority: normal Milestone: 8.0
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description (last modified by Samuel)

Encode-Locale is used in LWP, the others were added for Biber. Testing on an empty system with only the perl-5.24.0 core, using cpan, has shown they are not required and all the tests pass without them - also Biber-2.6's own tests and my own limited latex tests.

So, remove Encode-JIS2K and Encode-JISX0213.

Unfortunately, the extra deps for biber-2.6 will add several times that number of new modules.

Change History (7)

comment:1 by ken@…, 8 years ago

Status: newassigned

comment:2 by ken@…, 8 years ago

Summary: perl modules - remove Encode variants (except Encode-Locale).perl modules - remove Encode-JISX0213 and Encode-ISO2022

I was mistaken - Encode-EUCJPASCII, Encode-HanExtra and Encode-JIS2K are still deps of biber, but unlike many perl modules it manages to build without them and complete its tests.

Encode-JISX0213 is an optional dep for MIME-Charset, it can be safely removed (it deals with some sort of 7-bit encoding).

Encode-ISO2022 is a dep of Encode-JISX0213 so it too can safely go.

comment:3 by Samuel, 8 years ago

If it is ok with ken, I'll try create a patch for this one once my patch for VTE gets approved.

comment:4 by Samuel, 8 years ago

Description: modified (diff)

Fixed description is accordance with comment #2

in reply to:  3 comment:5 by ken@…, 8 years ago

Replying to Samuel:

If it is ok with ken, I'll try create a patch for this one once my patch for VTE gets approved.

Please don't. It's a very minor part of the whole (biber-2.6 and related changes), I'll do it along with removing the commented modules WHEN I have got to the end of listing the module dependencies (I've checked the deps for 88 modules so far, still another 8 to go plus anything else those pull in).

comment:6 by ken@…, 8 years ago

Resolution: fixed
Status: assignedclosed

Fixed as part of r17886.

comment:7 by bdubbs@…, 7 years ago

Milestone: 7.118.0

Milestone renamed

Note: See TracTickets for help on using tickets.