Opened 11 years ago

Closed 11 years ago

#3239 closed enhancement (fixed)

Kbd-1.15.5

Reported by: Matthew Burgess Owned by: Matthew Burgess
Priority: normal Milestone: 7.3
Component: Book Version: SVN
Severity: normal Keywords:
Cc:

Description

Change History (8)

comment:1 by bdubbs@…, 11 years ago

I'm not sure how to check everything, but these are my observations:

  • kbd-1.15.3-upstream_fixes-1.patch does not seem to be needed
  • kbd-1.15.3-backspace-1.patch IS needed and applies OK
  • Spanish translation has been fixed
  • builds ok without removing resizecons
  • configure needs --disable-vlock
    • vlock requires PAM

comment:2 by Matthew Burgess, 11 years ago

Owner: changed from lfs-book@… to Matthew Burgess
Status: newassigned

comment:3 by Matthew Burgess, 11 years ago

This breaks (well, interrupts) boot for me. The S70console script fails now. Analysing the failure, it's failing at:

      # Convert the keymap from $LEGACY_CHARSET to UTF-8
      [ -z "$LEGACY_CHARSET" ] ||
         dumpkeys -c "$LEGACY_CHARSET" | loadkeys -u >/dev/null 2>&1 ||
         failed=1

With

unknown keysym 'compose'
<stdin>:693: syntax error
syntax error in map file
key bindings not changed
Loading <stdin>

I'll report upstream, but for now I suggest we postpone the upgrade.

comment:4 by bdubbs@…, 11 years ago

What are you using for LEGACY_CHARSET?

in reply to:  4 comment:5 by Matthew Burgess, 11 years ago

Replying to bdubbs@…:

What are you using for LEGACY_CHARSET?

Here's my /etc/sysconfig/console:

UNICODE="1"
KEYMAP="uk"
LEGACY_CHARSET="iso-8859-1"
FONT="lat1-16"

comment:6 by bdubbs@…, 11 years ago

I think I found the error.

sed -i -e "326 s/if/while/" src/loadkeys.analyze.l

This is in a parsing routine that uses a stack and currently does not clear the stack properly at the end of a line when the stack depth is greater than 1.

This was in the diff posted to the kbd mailing list, but only one of the three changes was needed. Using the /etc/sysconfig/console settings above, the boot script works without complaint, but I can't check the keys with a US keyboard (AFAIK).

I'll note that I came up with the fix independently of the kbd mailing list with a few printf and echo statements in src/loadkeys.analyze.c and /etc/init.d/console.

Also, make regenerates loadkeys.analyze.c from the .l file with:

/bin/sh ../config/ylwrap loadkeys.analyze.l lex.yy.c loadkeys.analyze.c -- flex --header-file=/usr/src/kbd/kbd-1.15.5/src/loadkeys.analyze.h

comment:7 by Matthew Burgess, 11 years ago

Thanks, Bruce. I'm building now with that sed and will upgrade Kbd once I get a clean boot.

comment:8 by Matthew Burgess, 11 years ago

Resolution: fixed
Status: assignedclosed

Thanks again, Bruce. The sed works fine here too. Upgraded in r10086.

Note: See TracTickets for help on using tickets.