Opened 3 years ago

Closed 3 years ago

#10581 closed enhancement (fixed)

icu4c-61.1

Reported by: Bruce Dubbs Owned by: Pierre Labastie
Priority: normal Milestone: 8.3
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description

New version.

Attachments (1)

libreoffice-icu.patch (14.0 KB ) - added by Pierre Labastie 3 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 by Pierre Labastie, 3 years ago

Owner: changed from blfs-book to Pierre Labastie
Status: newassigned

comment:2 by ken@…, 3 years ago

I wanted to try this because binary texlive-2018 will use it: it breaks libreoffice if --with-system-icu is used:

[build CXX] i18npool/source/collator/gencoll_rule.cxx /scratch/working/libreoffice-6.0.1.1/i18npool/source/collator/gencoll_rule.cxx: In function 'int sal_main_with_args(int, char)': /scratch/working/libreoffice-6.0.1.1/i18npool/source/collator/gencoll_rule.cxx:116:35: error: 'RuleBasedCollator' was not declared in this scope

auto coll = o3tl::make_unique<RuleBasedCollator>(reinterpret_cast<const UChar *>(Obuf.getStr()), status);

/scratch/working/libreoffice-6.0.1.1/i18npool/source/collator/gencoll_rule.cxx:116:35: note: suggested alternative: In file included from /scratch/working/libreoffice-6.0.1.1/i18npool/source/collator/gencoll_rule.cxx:32:0: /usr/include/unicode/tblcoll.h:113:18: note: 'icu_61::RuleBasedCollator'

class U_I18N_API RuleBasedCollator : public Collator {

/scratch/working/libreoffice-6.0.1.1/i18npool/source/collator/gencoll_rule.cxx:116:108: error: no matching function for call to 'make_unique<<expression error> >(const sal_Unicode*, UErrorCode&)'

Similar build failures with LO-6.0.2.1 and 6.0.3.2.

Of the other packages mentioning icu in the book, I have so far successfully built libxml2, boost, js38, harfbuzz, raptor, firefox, postfix.

by Pierre Labastie, 3 years ago

Attachment: libreoffice-icu.patch added

comment:4 by Pierre Labastie, 3 years ago

Thanks to you both. it seems also that libreoffice upstream has addressed the namespace issue. I've attached a patch made from their commits.

comment:5 by Pierre Labastie, 3 years ago

It seems libreoffice builds with book instructions, just changing make build-notest to CPPFLAGS='-DU_USE_ICU_NAMESPACE=1' make build-notest. Much easier than patching...

Last edited 3 years ago by Pierre Labastie (previous) (diff)

comment:6 by Pierre Labastie, 3 years ago

Resolution: fixed
Status: assignedclosed

Fised at r20036

Note: See TracTickets for help on using tickets.