buggy patch of liboauth-1.0.3

[Xi Ruoyao]

The ​patch introduced a warning:

hash,c: In function 'oauth_verify_rsa_sha1':
hash.c:463:19: warning: passing argument 1 of 'EVP_MD_CTX_free' from incompatible pointer type [-Wincompatible-pointer-types]
    EVP_MD_CTX_free(pkey);
    
In file included from /usr/include/openssl/hmac.h:15,
                 from hash.c:363:
/usr/include/openssl/evp.h:499:34: note: expected 'EVP_MD_CTX *' {aka 'struct evp_md_ctx_st *'} but argument is of type 'EVP_PKEY *' {aka 'struct evp_pkey_st *'}
  void EVP_MD_CTX_free(EVP_MD_CTX *ctx);

Then the testsuite of liboauth-1.0.3 fails because of this. To fix this bug we should change hash.c:463 to be EVP_MD_CTX_free(md_ctx);.

[Xi Ruoyao]

fixed patch

[Douglas R. Reno]

Fetching everything that I know I'll get to in the next few days, per Bruce

[Douglas R. Reno]

I committed a rebased version to the patches repository at r3853.

The rebased version with your fix and one other will be in my next commit.

In addition, liboauth will now be available to sysv systems since Firefox now can optionally use it, and there is nothing systemd specific about it (it was originally placed in for libgdata and grilo).

[Douglas R. Reno]

Thanks again, Xi

Fixed at r20906