Opened 4 years ago

Closed 4 years ago

#11181 closed defect (fixed)

buggy patch of liboauth-1.0.3

Reported by: Xi Ruoyao Owned by: Douglas R. Reno
Priority: normal Milestone: 8.4
Component: BOOK Version: SVN
Severity: major Keywords:
Cc:

Description (last modified by Xi Ruoyao)

The patch introduced a warning:

hash,c: In function 'oauth_verify_rsa_sha1':
hash.c:463:19: warning: passing argument 1 of 'EVP_MD_CTX_free' from incompatible pointer type [-Wincompatible-pointer-types]
    EVP_MD_CTX_free(pkey);
    
In file included from /usr/include/openssl/hmac.h:15,
                 from hash.c:363:
/usr/include/openssl/evp.h:499:34: note: expected 'EVP_MD_CTX *' {aka 'struct evp_md_ctx_st *'} but argument is of type 'EVP_PKEY *' {aka 'struct evp_pkey_st *'}
  void EVP_MD_CTX_free(EVP_MD_CTX *ctx);

Then the testsuite of liboauth-1.0.3 fails because of this. To fix this bug we should change hash.c:463 to be EVP_MD_CTX_free(md_ctx);.

Attachments (1)

liboauth-1.0.3-openssl-1.1.0-2.patch (4.6 KB ) - added by Xi Ruoyao 4 years ago.
fixed patch

Download all attachments as: .zip

Change History (5)

by Xi Ruoyao, 4 years ago

fixed patch

comment:1 by Xi Ruoyao, 4 years ago

Description: modified (diff)

comment:2 by Douglas R. Reno, 4 years ago

Owner: changed from blfs-book to Douglas R. Reno
Status: newassigned

Fetching everything that I know I'll get to in the next few days, per Bruce

comment:3 by Douglas R. Reno, 4 years ago

I committed a rebased version to the patches repository at r3853.

The rebased version with your fix and one other will be in my next commit.

In addition, liboauth will now be available to sysv systems since Firefox now can optionally use it, and there is nothing systemd specific about it (it was originally placed in for libgdata and grilo).

comment:4 by Douglas R. Reno, 4 years ago

Resolution: fixed
Status: assignedclosed

Thanks again, Xi

Fixed at r20906

Note: See TracTickets for help on using tickets.