Opened 5 years ago

Closed 5 years ago

#11625 closed enhancement (fixed)


Reported by: Bruce Dubbs Owned by: Bruce Dubbs
Priority: normal Milestone: 8.4
Component: BOOK Version: SVN
Severity: normal Keywords:


New point version

Change History (2)

comment:1 by Bruce Dubbs, 5 years ago

  • Handle scroll wheel events with a discrete of 0

The driver currently assumes that any wheel event has a non-zero discrete value of 1. This is incorrect, it just hasn't triggered yet with any device.

With the hi-res scroll patches in place in the kernel and libinput, we may get wheel events with a discrete value of 0. We assume that if this ever happens, the device has some sensible click angle set so all we need to do is ignore the discrete 0 events and wait for the first discrete event to come.

Also add an explanatory comment too to make it clear the calculation is only done once.

  • Return the wheel scroll value instead of just the fraction

This is prep work for the hi-res work but right now, no real functional changes. It does however fix a bug where we used the vertial scroll dist for the horizontal wheel as well.

  • Split the scroll axis details up for easier extension

If we need more per-axis fields, it's easier to add this way.

  • conf: add an example snippet for how to assign options

Users still like to copy the whole file, potentially messing things up. Let's put a warning into the file directly that this is less than ideal.

  • Update bug URL for gitlab migration
  • Update README for gitlab migration
  • Remove two dead assignments

Value stored but never read.

comment:2 by Bruce Dubbs, 5 years ago

Resolution: fixed
Status: newclosed

Fixed at revision 21084.

Note: See TracTickets for help on using tickets.