Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#12067 closed enhancement (worksforme)

xine-lib is reported to not build against alsa-lib-1.1.9

Reported by: ken@… Owned by: blfs-book
Priority: normal Milestone: 9.0
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description (last modified by Bruce Dubbs)

From the xine-devel list (reformatted with added blank lines to try to stop trac making it totally unreadable)

# HG changeset patch
# User Xavier Bachelot <xavier@bachelot.org>
# Date 1557995649 -7200
#      Thu May 16 10:34:09 2019 +0200
# Node ID 673f6f42def382d02c6b75cfbce030f52e1bdaae
# Parent  a7e3e6825a9669e277965c1e6ab479cbfda04b0b

Fix alsa headers include path

alsa-lib 1.1.9 has changed the include paths in its pkgconfig to disallow the use of straight asoundlib.h in favor of the canonical alsa/asounlib.h. See for details: https://www.alsa-project.org/wiki/Detailed_changes_v1.1.8_v1.1.9#.2Finclude.2FMakefile.am

diff -r a7e3e6825a96 -r 673f6f42def3 src/audio_out/audio_alsa_out.c
--- a/src/audio_out/audio_alsa_out.c    Wed May 15 17:34:15 2019 +0200
+++ b/src/audio_out/audio_alsa_out.c    Thu May 16 10:34:09 2019 +0200
@@ -44,7 +44,7 @@
 #define ALSA_PCM_NEW_HW_PARAMS_API
 #define ALSA_PCM_NEW_SW_PARAMS_API
-#include <asoundlib.h>
+#include <alsa/asoundlib.h>
 #include <sys/ioctl.h>
 #include <inttypes.h>

I'm sure we can use a sed for that (I don't have 1.1.9 at the moment).

Change History (3)

comment:1 by Bruce Dubbs, 2 years ago

Description: modified (diff)

Use triple { construct to get literal trac text.

I just built xine-lib without issue. Looking at /usr/include, there still is asoundlib.h, but it's contents are:

$ cat asoundlib.h
#warning This header is deprecated, use <alsa/asoundlib.h> instead.
#include <alsa/asoundlib.h>

I don't think a change is needed at this time. This should be worksforme, but I'll hold off for now.

comment:2 by Bruce Dubbs, 2 years ago

Resolution: worksforme
Status: newclosed

comment:3 by Bruce Dubbs, 2 years ago

Milestone: 8.59.0

Milestone renamed

Note: See TracTickets for help on using tickets.